-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor release - Nova Icaria #197
Conversation
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
Split CIs for dev and master PRs
up nf version test
…/main.nf Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Shiny patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small suggestions, great job! 🚀
@JoseEspinosa I cannot directly push to dev so I made a PR to dev with your requested changes! |
Realease review jose fixes
Merged it! but seems that tests are failing now... |
Yes! I don;t know how this could not fail ont the other PR to dev, I forgot to change a couple of entries of test_nosheet vs test_no_sheet! They are tested also when merging to dev - so idk what happened. But I made a PR now to fix it, when the tests pass i'll tag it here :) |
Ok @JoseEspinosa here it goes #207 |
Fix test no sheet
Fix singularity config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! As the download issue is known we are good to go 🚀
Minor Release - 1.1.0 Nova Icaria
This fixes few bugs, improves the documentation and adds the possibility to avoid the samplesheet and toolsheet and pass direclty the input files and tools directives.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).