Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor release - Nova Icaria #197

Merged
merged 360 commits into from
Feb 21, 2025
Merged

Minor release - Nova Icaria #197

merged 360 commits into from
Feb 21, 2025

Conversation

luisas
Copy link
Collaborator

@luisas luisas commented Feb 12, 2025

Minor Release - 1.1.0 Nova Icaria

This fixes few bugs, improves the documentation and adds the possibility to avoid the samplesheet and toolsheet and pass direclty the input files and tools directives.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/multiplesequencealign branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small suggestions, great job! 🚀

@luisas
Copy link
Collaborator Author

luisas commented Feb 20, 2025

@JoseEspinosa I cannot directly push to dev so I made a PR to dev with your requested changes!

#206

@JoseEspinosa
Copy link
Member

@JoseEspinosa I cannot directly push to dev so I made a PR to dev with your requested changes!

#206

Merged it! but seems that tests are failing now...

@luisas
Copy link
Collaborator Author

luisas commented Feb 21, 2025

Yes! I don;t know how this could not fail ont the other PR to dev, I forgot to change a couple of entries of test_nosheet vs test_no_sheet!

They are tested also when merging to dev - so idk what happened. But I made a PR now to fix it, when the tests pass i'll tag it here :)

@luisas
Copy link
Collaborator Author

luisas commented Feb 21, 2025

Ok @JoseEspinosa here it goes #207

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! As the download issue is known we are good to go 🚀

@luisas luisas merged commit de24fb1 into master Feb 21, 2025
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants