Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpu support and alternative to samplesheet and toolsheet #189

Merged
merged 82 commits into from
Feb 3, 2025

Conversation

luisas
Copy link
Collaborator

@luisas luisas commented Feb 3, 2025

  • Update LearnMSA module and add support for GPUs (--use_gpu)
  • Add --aligner --args_aligner --tree --args_tree in alternative to the toolsheet
  • Add --seqs and --pdbs_dir in alternative to samplesheet
  • Improve documentation
  • Add new templates for the PRs
  • Add versions in in final summary csv

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/multiplesequencealign branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Feb 3, 2025

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 4c3de2d

+| ✅ 211 tests passed       |+
#| ❔   6 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-02-03 15:01:37

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small comments and suggestions, otherwise looks good!

luisas and others added 10 commits February 3, 2025 15:42
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
…/main.nf

Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
…/main.nf

Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@luisas luisas merged commit 52aefe4 into nf-core:dev Feb 3, 2025
25 checks passed
@luisas luisas deleted the add_gpu_suppor branch February 3, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants