Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First release review #161

Merged
merged 17 commits into from
Oct 1, 2024
Merged

First release review #161

merged 17 commits into from
Oct 1, 2024

Conversation

luisas
Copy link
Collaborator

@luisas luisas commented Sep 25, 2024

The corrections as prompted by the reviewers for the first release

Copy link

github-actions bot commented Sep 25, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5b51fcf

+| ✅ 192 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-10-01 08:10:30

@luisas luisas mentioned this pull request Sep 30, 2024
11 tasks
@luisas luisas merged commit 0df116a into dev Oct 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants