Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nf-test for kat/hist #6532

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Sep 2, 2024

Added nf-test for kat/hist with #6226

@GallVp GallVp requested review from mahesh-panchal and a team as code owners September 2, 2024 02:55
@GallVp GallVp requested review from vagkaratzas and removed request for a team September 2, 2024 02:55
@GallVp GallVp added help wanted Extra attention is needed conda-fail labels Sep 2, 2024
mahesh-panchal
mahesh-panchal previously approved these changes Sep 2, 2024
@mahesh-panchal mahesh-panchal added this pull request to the merge queue Sep 2, 2024
@mahesh-panchal mahesh-panchal removed this pull request from the merge queue due to a manual request Sep 2, 2024
@mahesh-panchal
Copy link
Member

I'm wondering if this module should be deprecated now. I don't think Kat is maintained anymore and there's both Merqury and MerquryFK now.

@GallVp
Copy link
Member Author

GallVp commented Sep 2, 2024

I'm wondering if this module should be deprecated now. I don't think Kat is maintained anymore and there's both Merqury and MerquryFK now.

Thanks @mahesh-panchal

The conda is also failing. If we agree to deprecate it, I'll remove the conda, add the deprecation message and ping you again for another look.

@mahesh-panchal
Copy link
Member

Do you know why conda is failing? I can't see what the error message is from the PR logs, but running in Gitpod, it's to do with needing to use the classic conda solver.

Bernardo hasn't made a release since 2018, and while the issues do seem active on the repository, I think the tool is in maintenance mode at best. The problem is, I'm also not sure how to do the deprecation note. Merqury is the maintained version of the tool, but only does a subset of what KAT does. MerquryFK does more, but isn't really maintained.

@GallVp
Copy link
Member Author

GallVp commented Sep 2, 2024

Do you know why conda is failing? I can't see what the error message is from the PR logs, but running in Gitpod, it's to do with needing to use the classic conda solver.

Bernardo hasn't made a release since 2018, and while the issues do seem active on the repository, I think the tool is in maintenance mode at best. The problem is, I'm also not sure how to do the deprecation note. Merqury is the maintained version of the tool, but only does a subset of what KAT does. MerquryFK does more, but isn't really maintained.

It says,

Plotting K-mer frequency distributions ... done. Saved to: None

corrupted double-linked list
.command.sh: line 6: 9563 Aborted (core dumped) kat hist --threads 2 --output_prefix test.hist -d test2_1.fastq.gz

It might be a memory related issue. But then docker and singularity have the same amount of memory. I'll try to pin the dependency versions to see if that helps.

@mahesh-panchal
Copy link
Member

Yeah, I don't know how to solve that. I've never come across it before.

@famosab famosab requested a review from a team as a code owner February 11, 2025 11:52
Copy link
Contributor

@vagkaratzas vagkaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Other than the java.lang.NullPointerException: Cannot invoke method getAt() on null object for Docker and Conda, it looks good.

- conda-forge::python=3.8.5 # Locked with the container
- conda-forge::numpy=1.19.1 # Locked with the container
- conda-forge::scipy=1.5.2 # Locked with the container
- conda-forge::matplotlib=3.3.1 # Locked with the container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to specify these separately here? Are they not included in the bioconda::kat environment anyway?
What does # Locked with the container imply?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-fail help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants