-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nf-test for kat/hist #6532
base: master
Are you sure you want to change the base?
Conversation
I'm wondering if this module should be deprecated now. I don't think Kat is maintained anymore and there's both Merqury and MerquryFK now. |
Thanks @mahesh-panchal The conda is also failing. If we agree to deprecate it, I'll remove the conda, add the deprecation message and ping you again for another look. |
Do you know why conda is failing? I can't see what the error message is from the PR logs, but running in Gitpod, it's to do with needing to use the classic conda solver. Bernardo hasn't made a release since 2018, and while the issues do seem active on the repository, I think the tool is in maintenance mode at best. The problem is, I'm also not sure how to do the deprecation note. Merqury is the maintained version of the tool, but only does a subset of what KAT does. MerquryFK does more, but isn't really maintained. |
It says,
It might be a memory related issue. But then docker and singularity have the same amount of memory. I'll try to pin the dependency versions to see if that helps. |
Yeah, I don't know how to solve that. I've never come across it before. |
8457b2b
to
080a251
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. Other than the java.lang.NullPointerException: Cannot invoke method getAt() on null object for Docker and Conda
, it looks good.
- conda-forge::python=3.8.5 # Locked with the container | ||
- conda-forge::numpy=1.19.1 # Locked with the container | ||
- conda-forge::scipy=1.5.2 # Locked with the container | ||
- conda-forge::matplotlib=3.3.1 # Locked with the container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to specify these separately here? Are they not included in the bioconda::kat
environment anyway?
What does # Locked with the container
imply?
Added nf-test for kat/hist with #6226