-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merging lanes from baminput #1111
base: dev
Are you sure you want to change the base?
Conversation
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.1.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Some minor comments and minor code cleanup.
- Please remove the original input bam indexing section (I believe it is not needed anymore?)
- There was a channel or two created but not used downstream. Please remove unused code.
Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbv2!
Please give the modules in the subworkflow unique names, and their own section in the modules.config.
Currently this should work fine, but when the output restructuring takes place, it will be needed to separate the mapping outputs from the bam_input outputs.
Otherwise this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jbv2 ! Minor changes then ready to merge.
- The name of the flagstat module in the config did not match the name in the code. I think I got all cases in my suggestions. Please double-check.
- Minor change in ordering of attributes in modules config to match code conventions
No description provided.