Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk update of modules and subworkflows for 2.1.0 release #410

Merged
merged 13 commits into from
Aug 9, 2024
Merged

Bulk update of modules and subworkflows for 2.1.0 release #410

merged 13 commits into from
Aug 9, 2024

Conversation

JoseEspinosa
Copy link
Member

@JoseEspinosa JoseEspinosa commented Aug 6, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

Closes #409

@JoseEspinosa JoseEspinosa changed the title Bulk update of modules for 2.1.0 release Bulk update of modules and subworkflows for 2.1.0 release Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2cc4f57

+| ✅ 223 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-08 17:11:05

@JoseEspinosa JoseEspinosa marked this pull request as ready for review August 6, 2024 16:04
mashehu
mashehu approved these changes Aug 7, 2024
View reviewed changes
CHANGELOG.md
@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [[#378](https://github.com/nf-core/chipseq/issues/378)] - Switch from macs2 to macs3.
- [[#347](https://github.com/nf-core/chipseq/issues/347)] - Add read group tag to bam files processed by bowtie2.
- [[PR #406](https://github.com/nf-core/chipseq/pull/406)] - Update metro map to show macs3 instead of macs2.
- [[#409](https://github.com/nf-core/chipseq/issues/409)] - Bulk modules and subworkflows update.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a list of which ones were updated would be helpful to figure out where behavior might have changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I updated the changelog to show the versions updated here

@JoseEspinosa JoseEspinosa merged commit 686c054 into nf-core:dev Aug 9, 2024
9 checks passed
@JoseEspinosa JoseEspinosa mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseEspinosa @mashehu