Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug fix in NVM ELF loader #62

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Small bug fix in NVM ELF loader #62

merged 2 commits into from
Feb 7, 2024

Conversation

govereau
Copy link
Contributor

@govereau govereau commented Feb 7, 2024

No description provided.

slumber
slumber approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@slumber slumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate a small clarifying comment for those who are out of context

@govereau
Copy link
Contributor Author

govereau commented Feb 7, 2024

The riscv parser will consume 4 bytes each time it is called (in the current nexus_rt setup), because all riscv instructions are four bytes. So, we have to increment by four after each call.

Base automatically changed from pg-remove to main February 7, 2024 13:22
@govereau govereau merged commit 8ec0d31 into main Feb 7, 2024
4 checks passed
@govereau govereau deleted the pg-bugfix branch February 7, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slumber slumber slumber approved these changes

@danielmarinq danielmarinq Awaiting requested review from danielmarinq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@govereau @slumber