fix: improve R1CS folding test to verify cross-terms #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test previously only checked folding of identical instances, missing cross-term verification. Description ----------- Now it: - Tests different R1CS instances (x=3 and x=-2) - Explicitly verifies cross-term computation (Az₁Bz₂ + Az₂Bz₁ - u₁Cz₂ - u₂Cz₁) - Verifies the complete folding operation with different instances Testing the introduced fix -------------------------- clone this pr branch and from the root directory, run: ---- cargo test --package nexus-nova --lib -- r1cs::tests::folded_with_relaxed_instance_is_satisfied --exact --show-output ----
|
Thank you for this, we will review. |
Thanks, feel free to let me know if you have any questions |
sjudson
approved these changes
Jan 8, 2025
Hi @sjudson, thanks |
0xObsidian
deleted the
0xObsidian/improve-R1CS-folding-to-verify-crossterms
branch
sjudson
added a commit
that referenced
this pull request
Feb 12, 2025
* Baby steps towards porting over sdk. * Sketch out updated traits. * More work on new traits. * More prep work. * Move macros inboard to SDK and do a lot more prep. * Incremental work towards building with nova. * More work on Nova translation. * Get Nova set. * Get building with serialization. * Make some lifetimes easier to manage. * Minor. * Work on examples. * Add legacy examples. * Get example building working. * Start working on HyperNova * Work around strange issue with implementation. * Get hypernova example working. * Port over Jolt. * Format. * Some trait cleaning up. * More formatting. * Even more formatting. * Fix dependency. * Fix traits and some implementations * Minor. * Try to fix CI error. * Fix. * Clippy. * Clean up .cargo. * Fix CI. * Update integration tests. * Start to work on Stwo integration. * More work. * More cleaning up of components. * A lot of cleanup + redesign work. * Add log capturing. * More redesign of log handling. * Big format. * More work towards final version. * Finish out compilation. * Minor fixes and improvements. * Extend use of InternalView for tests. * Fix change. * Fixes and formatting. * Sketch out verification interfaces * A lot of cleanup. * More fixing. * Getting there. * Finish verification. * Almost there... * Get building. * Some clippy. * Finish clippy. * Format. * Fixing tests. * Format. * Get building. * Formatting * Minor. * More. * Somehow even more. * Oh please make it stop... * Improved logging elements. * Fix tests. * Fix * More formatting. * Start to work on examples. * Get first example working. * Get all examples working via COBS. * Clippy * Format. * Update sdk/macros/Cargo.toml Co-authored-by: Ben Hoberman <bhoberman@users.noreply.github.com> * Minor. * Fix testing infrastructure. * Format. * Move utility functions. * Format. * Fix cargo config. * Fix branch. * Fix no input examples. * Getting legacy examples working... * Add feature gating. * Port over minimal cli with host program setup. * Update README. * Format. * Update header. * Typo. * More formatting. * A few last fixes. * Fix doctest. * Temp improve main readme. * Spruce up readme a bit more. * Remove some todos. * Add some clarifying comments. * Carry raw logs. --------- Co-authored-by: Ben Hoberman <bhoberman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test previously only checked folding of identical instances, missing cross-term verification.
Description
Now it:
R1CSinstances(x=3 and x=-2)(Az₁Bz₂ + Az₂Bz₁ - u₁Cz₂ - u₂Cz₁)Testing the introduced
fixclone this pr branch and from the root directory, run:
Impact
This PR closes ticket #288