Add PCS types and basic setup flow using SRS #28

tess-eract · 2023-12-23T02:27:43Z

This adds some basic support for generating public parameters from a SRS for a polynomial commitment scheme.

* cleanup secondary circuit code * rework relaxed nimfs * fix circuits * run bench build in the same profile * reduce the number of bits to 127

govereau · 2024-01-09T15:23:04Z

This looks good. However, I think the last patch (merge of main) is not right. Did you want to rebase the two commits not in main onto main?

* cleanup secondary circuit code * rework relaxed nimfs * fix circuits * run bench build in the same profile * reduce the number of bits to 127

slumber · 2024-02-28T17:00:10Z

.gitignore

+
+# public parameter files
+*.zst


This is supposed to used cache folder. If postponed for later, newline missing

prover/src/main.rs

slumber · 2024-02-28T17:02:25Z

prover/src/pp.rs

 {
    let f = File::open(file)?;
    let mut dec = Decoder::new(&f)?;
-    let pp = PP::<SP>::deserialize_compressed(&mut dec)?;
+    let pp = PP::<C, SP>::deserialize_compressed_unchecked(&mut dec)?;


Why is this change needed?

I thought it wouldn't make a difference anymore due to the arkworks update: is
this not true?

slumber · 2024-02-28T17:03:21Z

prover/src/pp.rs

    SC: StepCircuit<F1> + Sync,
-    SP: SetupParams<G1, G2, C1, C2, RO, SC> + Sync,
+    SP: SetupParams<G1, G2, C, C2, RO, SC> + Sync,


We should keep C1 C2 notation

C1 is a type alias for Pedersen: here, we want C to be generic so it works
for PVC as well.

Didn't notice it because of wildcard imports unfortunately

prover/src/pp.rs

vercel · 2024-03-01T14:25:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nexus-docs	❌ Failed (Inspect)			Mar 8, 2024 6:52pm

prover/src/pp.rs

slumber · 2024-03-04T12:30:54Z

prover/src/pp.rs

    SC: StepCircuit<F1> + Sync,
-    SP: SetupParams<G1, G2, C1, C2, RO, SC> + Sync,
+    SP: SetupParams<G1, G2, C, C2, RO, SC> + Sync,


Didn't notice it because of wildcard imports unfortunately

slumber · 2024-03-04T12:31:28Z

prover/src/srs.rs

+    pub fn gen_test_srs(num_vars: usize) -> Result<SRS, ProofError> {
+        let mut rng = test_rng();
+        PC::setup(num_vars, b"test_srs", &mut rng).map_err(|_| ProofError::SRSSamplingError)
+    }
+
+    pub fn save_srs(srs: SRS, file: &str) -> Result<(), ProofError> {
+        let f = File::create(file)?;
+        let mut enc = Encoder::new(&f, 0)?;
+        srs.serialize_compressed(&mut enc)?;
+        enc.finish()?;
+        f.sync_all()?;
+        Ok(())
+    }
+
+    pub fn gen_test_srs_to_file(poly_length: usize, file: &str) -> Result<(), ProofError> {
+        let srs = gen_test_srs(poly_length)?;
+        save_srs(srs, file)
+    }


these aren't tests; the compression-cli PR will introduce a CLI command to call into these. the word test is in the name to emphasize that an SRS generated this way is insecure and not to be used in production.

* testing proof deserialization * proofs save and verify * removed cargo.lock * todo: merge dorebell onto this * fixed merge mistakes * reads proof and compresses. key not yet saved to file * added back cargo.lock * moved the compression cli into prover crate * formatting * remove whitespace * added com option to prove * updated local prove * todo:save key and proof to file * derive CanonicalSerialize+CanonicalDeserialize for Spartan types * add options to save and load spartan key from file * save compressed proof to file, implement arkworks serialization * clippy * remove SRS generation from CI * ignore spartan_encode_test * integrate compression cli with recent version of nexus-tools * add cli function to sample test SRS * forgot to add new files * small compression UI fixes * add spartan setup command to main 'cargo nexus' * bump number of SRS vars to 27 * minor fix * review fixes * another round of review fixes * read pp and srs from default cache locations if unspecified during compression * add helper function to get minimum srs size for a given k --------- Co-authored-by: Dan Dore <dorebell@gmail.com>

* Initial CCS implementation. * Remove direct construction interfaces so that everything goes through R1CS. * Trim more, Fold multipliers together, and inline satisfaction checking. * Fix formatting. * Precompute products. * Remove direct CCS construction. * Add mle helpers. * Start to integrate polynomial commitments. * Shading closer to polynomial commitments. * Initial stab at relating various polynomial types and traits. * Finish utility functions. * Fix endianness and ranges and get tests passing. * Fix formatting. * Realized there's a better way to invoke the partially fixed polynomial. * Update interfaces and some additional reworking. * Resolve clippy. * Unify shapes. * Product renaming Co-authored-by: Dan Dore <dorebell@gmail.com> * Revert "Unify shapes." This reverts commit 3463e43. * Move to polynomial/poly commitment implementations from Spartan repo. * Move to unified matrix-based model. * Fix tests. * Fix fmt. * Remove files accidently restored during rebase. * Move to using polynomial commitment exlcusively. * Fix formatting. --------- Co-authored-by: Dan Dore <dorebell@gmail.com>

* Update README.md * Update README.md * Create .all-contributorsrc

* docs: update README.md * docs: update .all-contributorsrc --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Delete .all-contributorsrc * Update README.md

tess-eract changed the base branch from main to dorebell-setup-patch January 4, 2024 22:38

tess-eract mentioned this pull request Jan 4, 2024

Integrate the compression functionality into the prover and network crates #29

Closed

4 tasks

tess-eract linked an issue Jan 4, 2024 that may be closed by this pull request

Integrate the compression functionality into the prover and network crates #29

Closed

4 tasks

govereau pushed a commit that referenced this pull request Jan 5, 2024

reduce the size of secondary circuit (#28)

f01f2a6

* cleanup secondary circuit code * rework relaxed nimfs * fix circuits * run bench build in the same profile * reduce the number of bits to 127

tess-eract marked this pull request as ready for review January 5, 2024 20:48

tess-eract changed the base branch from dorebell-setup-patch to main January 5, 2024 20:50

tess-eract requested a review from govereau January 5, 2024 20:50

tess-eract removed a link to an issue Jan 8, 2024

Integrate the compression functionality into the prover and network crates #29

Closed

4 tasks

govereau pushed a commit that referenced this pull request Jan 9, 2024

reduce the size of secondary circuit (#28)

9749dd2

* cleanup secondary circuit code * rework relaxed nimfs * fix circuits * run bench build in the same profile * reduce the number of bits to 127

tess-eract added 4 commits January 12, 2024 16:20

add basic setup flow using SRS

7908746

merge with main

6daf154

some small fixes to bugs in the compression module from recent PRs

c565050

spartan integration fixes

9964e5a

tess-eract force-pushed the dorebell-SRS branch from cd811ab to 9964e5a Compare January 13, 2024 00:38

tests for srs generation

333a8c0

tess-eract marked this pull request as draft January 30, 2024 01:18

sets default srs size to 19

46fd1e0

tess-eract marked this pull request as ready for review January 30, 2024 01:27

tess-eract marked this pull request as draft January 31, 2024 19:00

tess-eract added 4 commits February 1, 2024 16:16

use deserialize_compressed_unchecked

3a2f699

remove unnecessary blinding factor from SRS generation

223ca68

merge

0966eb3

fix

335434d

tess-eract marked this pull request as ready for review February 2, 2024 02:07

tess-eract added 5 commits February 1, 2024 18:13

adds SRS to git lfs

d141b6a

Merge branch 'main' into dorebell-SRS

bc264a9

add git lfs to CI workflow

13f6f7b

sample test srs in CI

04a1498

install nexus-tools in CI

3344793

Merge branch 'main' into dorebell-SRS

cf501e9

slumber reviewed Feb 28, 2024

View reviewed changes

fixes from review

78e6def

vercel bot had a problem deploying to Preview March 1, 2024 14:25 Failure

Merge branch 'main' into dorebell-SRS

a72f675

vercel bot deployed to Preview March 1, 2024 14:40 View deployment

small fix

42000df

tess-eract requested review from slumber and guruvamsi-policharla March 1, 2024 22:51

vercel bot deployed to Preview March 1, 2024 22:56 View deployment

slumber reviewed Mar 4, 2024

View reviewed changes

remove file-manipulating tests

86c1c53

tess-eract requested a review from slumber March 6, 2024 02:03

vercel bot deployed to Preview March 6, 2024 02:04 View deployment

vercel bot had a problem deploying to Preview March 8, 2024 17:59 Failure

danielmarinq and others added 5 commits March 8, 2024 10:02

fix broken edit links in docs (#99)

f605d58

All Contributors Setup (#120)

e089469

* Update README.md * Update README.md * Create .all-contributorsrc

docs: add nexus-xyz as a contributor for code (#121)

c3e03ad

* docs: update README.md * docs: update .all-contributorsrc --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

Switch Contributors (#122)

89adc29

* Delete .all-contributorsrc * Update README.md

vercel bot had a problem deploying to Preview March 8, 2024 18:02 Failure

Merge branch 'main' into dorebell-SRS

88b17e1

vercel bot had a problem deploying to Preview March 8, 2024 18:20 Failure

fix merge conflicts

501879b

vercel bot had a problem deploying to Preview March 8, 2024 18:52 Failure

slumber approved these changes Mar 11, 2024

View reviewed changes

tess-eract merged commit 6045c59 into main Mar 14, 2024
5 of 6 checks passed

tess-eract deleted the dorebell-SRS branch March 14, 2024 11:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PCS types and basic setup flow using SRS #28

Add PCS types and basic setup flow using SRS #28

tess-eract commented Dec 23, 2023 •

edited

Loading

govereau commented Jan 9, 2024

slumber Feb 28, 2024

slumber Feb 28, 2024

tess-eract Mar 1, 2024

slumber Feb 28, 2024

tess-eract Mar 1, 2024

slumber Mar 4, 2024

vercel bot commented Mar 1, 2024 •

edited

Loading

slumber Mar 4, 2024

slumber Mar 4, 2024

tess-eract Mar 6, 2024

Add PCS types and basic setup flow using SRS #28

Add PCS types and basic setup flow using SRS #28

Conversation

tess-eract commented Dec 23, 2023 • edited Loading

govereau commented Jan 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Mar 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tess-eract commented Dec 23, 2023 •

edited

Loading

vercel bot commented Mar 1, 2024 •

edited

Loading