Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "spartan" feature #147

Open
slumber opened this issue Apr 22, 2024 · 2 comments
Open

fix "spartan" feature #147

slumber opened this issue Apr 22, 2024 · 2 comments

Comments

@slumber
Copy link
Contributor

slumber commented Apr 22, 2024

Initially it was optional for proof compression, with the implementation of HyperNova the codebase gets even more tied to polycommitments interface.

Alternative solution is to extract this code into another crate and remove "spartan" feature-gate from HyperNova, but this is more involved.
@slumber slumber mentioned this issue Jul 13, 2024
Merged
@slumber slumber changed the title remove "spartan" feature fix "spartan" feature Jul 13, 2024
@sjudson
Copy link
Contributor

sjudson commented Jul 16, 2024

Resolved by #223

@sjudson sjudson closed this as completed Jul 16, 2024
@slumber
Copy link
Contributor Author

slumber commented Jul 16, 2024

Please keep it open to allow spartan being optional

@slumber slumber reopened this Jul 16, 2024
sjudson pushed a commit that referenced this issue Feb 5, 2025
@bhoberman @sjudson
Precompile Metadata is Embedded into ELFs (#147)
717ba39 
* Update Macro

* Reorg + Fixes

* ELF Loader Loads Custom Metadata

* Quick Self-Review

* Change Segment Type + Fix Parser

* Clippy Bypass -> Target Config
sjudson pushed a commit that referenced this issue Feb 12, 2025
@bhoberman @sjudson
Precompile Metadata is Embedded into ELFs (#147)
6b571b0 
* Update Macro

* Reorg + Fixes

* ELF Loader Loads Custom Metadata

* Quick Self-Review

* Change Segment Type + Fix Parser

* Clippy Bypass -> Target Config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjudson @slumber