mwe of halo exchange #744
Draft
mwe of halo exchange #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I changed the logic for determining whether the Docker workflow is run. I an attempt to fix the test failure https://github.com/nextsimhub/nextsimdg/actions/runs/12009927720/job/33475689562 might it be feasible to rebase on top of or merge in Compare https://github.com/nextsimhub/nextsimdg/blob/halo-exchange/.github/workflows/docker.yml vs https://github.com/nextsimhub/nextsimdg/blob/develop/.github/workflows/docker.yml. |
TomMelt
force-pushed
the
halo-exchange
branch
from
b3882c1 to
7c3adbb
Compare
TomMelt
force-pushed
the
melt-mpi-metadata
branch
from
88f9e68 to
63e6f77
Compare
TomMelt
force-pushed
the
halo-exchange
branch
from
3adf0d1 to
e5c31a6
Compare
TomMelt
force-pushed
the
halo-exchange
branch
from
e5c31a6 to
d1b8951
Compare
TomMelt
force-pushed
the
melt-mpi-metadata
branch
from
63e6f77 to
aa15779
Compare
TomMelt
force-pushed
the
halo-exchange
branch
2 times, most recently
from
980be5e to
a989bb6
Compare
TomMelt
commented
Jan 6, 2025
Comment on lines
+103
to
+172
| template <typename T> T& copyToBuffer(T& buffer, size_t startIndex = 0) | ||
| { | ||
| // make no especial attempt at efficiency here | ||
| SliceIter thisIter(slice, data.dimensions()); | ||
| auto biter = buffer.begin(); | ||
| auto biter = std::next(buffer.begin(), startIndex); |
There was a problem hiding this comment.
@timspainNERSC this was a bit hacky from me. I want to populate the buffer but from a specific starting index. Let me know if there's a better way of doing this.
I was trying to avoid creating temporary arrays for each of the edges.
TomMelt
commented
Jan 6, 2025
TomMelt
commented
Jan 6, 2025
TomMelt
force-pushed
the
melt-mpi-metadata
branch
from
aa15779 to
319b07e
Compare
TomMelt
force-pushed
the
halo-exchange
branch
from
a989bb6 to
60cfca0
Compare
This test includes two examples for different grid layouts: - 3 x 1 grid (3 procs) - 2 x 2 grid (4 procs) Makes use of the Slice functionality
TomMelt
force-pushed
the
halo-exchange
branch
from
60cfca0 to
1434d31
Compare
TomMelt
force-pushed
the
halo-exchange
branch
2 times, most recently
from
184f77a to
5cde88d
Compare
TomMelt
force-pushed
the
halo-exchange
branch
from
5cde88d to
9346539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small MWE of halo exchange logic for testing before add the main functionality to nextsim
core/src/include/Halo.hpp