Changed converting enum from and to raw values + added support for Ba… #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckedEnum in {default} property modifiers
hrach
reviewed
Nov 4, 2023
|
cc @Zazimou |
… Early return for default enum on entity property plus returned back intendation of previous code in ModifierParser, Added tests
|
Thanks, the bug is clear to me now, the fix is correct now, but I'll have to go over the test, ideally, I don't want to add more entities/tables to the test suit. Isn't possible to test it on existing infrastructure? |
|
Tests reworked :-) |
|
cc @hrach |
|
Could you please make the test pass? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ckedEnum in {default} property modifiers