Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Visual Studio and Visual Studio Code files #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore Visual Studio and Visual Studio Code files #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,14 @@
*.dSYM/

# Build
/build*
/*build*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous mask /build* was for:

  1. build folder - for out of source builds
  2. build-Debug, build-Release, etc - QtCreator usually naming for out of source builds (latest versions create such folders in parent directory)

And what cases the mask like your /build for? Not sure that in future some GDAL sources folder may affected by this mask.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows more flexibility, eg. to name build folders like _build64 and _build32. This is convenient, moves it in directory listing to the top, visually distinct, etc.

/inst

# Visual Studio / Visual Studio Code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what case the VS files can be appeared in sources tree?

Usually the GDAL build appear by following steps:

git clone https://github.com/nextgis-borsch/lib_gdal.git
cd lib_gdal
mkdir build
cd build
cmake -DBUILD_SHARED_LIBS=ON -DWITH_EXPAT=ON -DWITH_EXPAT_EXTERNAL=ON -DWITH_GeoTIFF=ON -DWITH_GeoTIFF_EXTERNAL=ON -DWITH_ICONV=ON -DWITH_ICONV_EXTERNAL=ON -DWITH_JSONC=ON -DWITH_JSONC_EXTERNAL=ON -DWITH_LibXml2=ON -DWITH_LibXml2_EXTERNAL=ON -DWITH_PROJ4=ON -DWITH_PROJ4_EXTERNAL=ON -DWITH_TIFF=ON -DWITH_TIFF_EXTERNAL=ON -DWITH_ZLIB=ON -DWITH_ZLIB_EXTERNAL=ON -DWITH_JBIG=ON -DWITH_JBIG_EXTERNAL=ON -DWITH_JPEG=ON -DWITH_JPEG_EXTERNAL=ON -DWITH_JPEG12=ON -DWITH_JPEG12_EXTERNAL=ON -DWITH_LibLZMA=ON -DWITH_LibLZMA_EXTERNAL=ON -DWITH_GEOS=ON -DWITH_GEOS_EXTERNAL=ON -DWITH_PYTHON=ON -DWITH_PYTHON3=OFF -DWITH_SQLite3=ON -DWITH_SQLite3_EXTERNAL=ON -DWITH_PNG=ON -DWITH_PNG_EXTERNAL=ON -DWITH_CURL=ON -DWITH_CURL_EXTERNAL=ON -DWITH_OpenSSL=ON -DWITH_OpenSSL_EXTERNAL=ON -DENABLE_OZI=ON -DWITH_PostgreSQL=ON -DWITH_PostgreSQL_EXTERNAL=ON -DENABLE_NITF_RPFTOC_ECRGTOC=ON -DENABLE_HDF4=ON -DWITH_HDF4=ON -DWITH_HDF4_EXTERNAL=ON -DENABLE_ECW=ON -DWITH_ECW=ON -DWITH_ECW_EXTERNAL=ON -DENABLE_MRSID=ON -DWITH_MRSID=ON -DWITH_MRSID_EXTERNAL=ON -DGDAL_ENABLE_GNM=ON -G "Visual Studio 12 2013" -T "v120_xp" ../
cmake --build . --config release

In such way everything will be in build folder.

Do you see the mapping file (https://github.com/nextgis-borsch/lib_gdal/blob/master/opt/folders.csv) which describes how original sources should be stored in destination sources tree?

Copy link
Author

@mloskot mloskot Mar 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cases are:

  • Use the latest/greatest VS2017 CMake integration (/.vs folder is created in the source tree)
  • Open GDAL folder in Visual Studio Code (/.vscode folder is created in the source tree), then I can configure C++ debugger (/.vscode/launch.json) and many more to work with GDAL in VSCode.

IOW, the additional pattern allow typical workflows with VS2017 and VSCode

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the GDAL build appear by following steps:
[...]

Yes, that is a typical CMake command line-based workflow.
However, the CMake integration in latest VS2017 handles out-of-source builds slightly differently.

Do you see the mapping file (https://github.com/nextgis-borsch/lib_gdal/blob/master/opt/folders.csv) ...?

I'm not sure how folders.csv relates to the matter of this PR.

/.vs
/.vscode
/CMakeSettings.json

# Temp
*~
.~*
Expand Down