Ignore Visual Studio and Visual Studio Code files #12
Conversation
| @@ -32,9 +32,14 @@ | |||
| *.dSYM/ | |||
|
|
|||
| # Build | |||
| /build* | |||
| /*build* | |||
There was a problem hiding this comment.
The previous mask /build* was for:
- build folder - for out of source builds
- build-Debug, build-Release, etc - QtCreator usually naming for out of source builds (latest versions create such folders in parent directory)
And what cases the mask like your /build for? Not sure that in future some GDAL sources folder may affected by this mask.
There was a problem hiding this comment.
It allows more flexibility, eg. to name build folders like _build64 and _build32. This is convenient, moves it in directory listing to the top, visually distinct, etc.
| /inst | ||
|
|
||
| # Visual Studio / Visual Studio Code |
There was a problem hiding this comment.
In what case the VS files can be appeared in sources tree?
Usually the GDAL build appear by following steps:
git clone https://github.com/nextgis-borsch/lib_gdal.git
cd lib_gdal
mkdir build
cd build
cmake -DBUILD_SHARED_LIBS=ON -DWITH_EXPAT=ON -DWITH_EXPAT_EXTERNAL=ON -DWITH_GeoTIFF=ON -DWITH_GeoTIFF_EXTERNAL=ON -DWITH_ICONV=ON -DWITH_ICONV_EXTERNAL=ON -DWITH_JSONC=ON -DWITH_JSONC_EXTERNAL=ON -DWITH_LibXml2=ON -DWITH_LibXml2_EXTERNAL=ON -DWITH_PROJ4=ON -DWITH_PROJ4_EXTERNAL=ON -DWITH_TIFF=ON -DWITH_TIFF_EXTERNAL=ON -DWITH_ZLIB=ON -DWITH_ZLIB_EXTERNAL=ON -DWITH_JBIG=ON -DWITH_JBIG_EXTERNAL=ON -DWITH_JPEG=ON -DWITH_JPEG_EXTERNAL=ON -DWITH_JPEG12=ON -DWITH_JPEG12_EXTERNAL=ON -DWITH_LibLZMA=ON -DWITH_LibLZMA_EXTERNAL=ON -DWITH_GEOS=ON -DWITH_GEOS_EXTERNAL=ON -DWITH_PYTHON=ON -DWITH_PYTHON3=OFF -DWITH_SQLite3=ON -DWITH_SQLite3_EXTERNAL=ON -DWITH_PNG=ON -DWITH_PNG_EXTERNAL=ON -DWITH_CURL=ON -DWITH_CURL_EXTERNAL=ON -DWITH_OpenSSL=ON -DWITH_OpenSSL_EXTERNAL=ON -DENABLE_OZI=ON -DWITH_PostgreSQL=ON -DWITH_PostgreSQL_EXTERNAL=ON -DENABLE_NITF_RPFTOC_ECRGTOC=ON -DENABLE_HDF4=ON -DWITH_HDF4=ON -DWITH_HDF4_EXTERNAL=ON -DENABLE_ECW=ON -DWITH_ECW=ON -DWITH_ECW_EXTERNAL=ON -DENABLE_MRSID=ON -DWITH_MRSID=ON -DWITH_MRSID_EXTERNAL=ON -DGDAL_ENABLE_GNM=ON -G "Visual Studio 12 2013" -T "v120_xp" ../
cmake --build . --config release
In such way everything will be in build folder.
Do you see the mapping file (https://github.com/nextgis-borsch/lib_gdal/blob/master/opt/folders.csv) which describes how original sources should be stored in destination sources tree?
There was a problem hiding this comment.
The cases are:
- Use the latest/greatest VS2017 CMake integration (
/.vsfolder is created in the source tree) - Open GDAL folder in Visual Studio Code (
/.vscodefolder is created in the source tree), then I can configure C++ debugger (/.vscode/launch.json) and many more to work with GDAL in VSCode.
IOW, the additional pattern allow typical workflows with VS2017 and VSCode
There was a problem hiding this comment.
Usually the GDAL build appear by following steps:
[...]
Yes, that is a typical CMake command line-based workflow.
However, the CMake integration in latest VS2017 handles out-of-source builds slightly differently.
Do you see the mapping file (https://github.com/nextgis-borsch/lib_gdal/blob/master/opt/folders.csv) ...?
I'm not sure how folders.csv relates to the matter of this PR.
A test PR :)