Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom datadirectory (i.e. not called data) located in Nextcloud installation folder #201

Open
TRILOS opened this issue Jan 9, 2019 · 8 comments

Comments

@TRILOS
Copy link

TRILOS commented Jan 9, 2019

Updating NC 14.0.3 to .4 failed at "Check for expected files":
"The following extra files have been found:
o [custom pathname for file repository]
o .well-known"

Update does not continue.

  1. These are not "files" but directories. Please be exact.

  2. Custom pathname for file repository has been defined, Update has to respect this.

  3. ".well know" is a required directory for automatic verification to get a Let´s Encrypt SSL certificate by a widespread Plesk Panel extension. Update should tolerate this.

  4. These are two conditions which should not break the update process. Using a software to keep the personal data in own hands should per se not deny the user´s wish.

  5. Update routine of NC 14.0.03 seems to be unable to continue. May be a patch file is required.

  6. This issue seems to be very, very old, see "Check for expected files" fails with custom data directory #92

@kesselb
Copy link
Contributor

kesselb commented Jan 9, 2019

.well know" is a required directory for automatic verification to get a Let´s Encrypt SSL certificate by a widespread Plesk Panel extension. Update should tolerate this.

#183 (not sure if this feature is available for nextcloud 14)

Custom pathname for file repository has been defined, Update has to respect this.

  • directory is not inside the nextcloud root ✔️
  • directory name is data ✔️
  • directory inside nextcloud root but not called data

$expected = [

Name of the directory should be added to this list. Not sure howto solve this properly because datadirectory could be an absolute or relative value and inside or outside the nextcloud root. I would always recommend to move the directory outside the webroot but i agree with you that the updater should not care about it 🤔

@iromeister
Copy link

iromeister commented May 20, 2019

At least the updater should give the option to ignore existing files and directories. A warning would be OK for me.
Btw, I ran across this issue on update from 16 to 16.01.

@mfeske
Copy link

mfeske commented Sep 9, 2021

I don't get a query whether I want to ignore the files. A change to the updater / index.php only affects the web update, what do I have to do so that files at /updater/updater.phar -n are ignored

@AlphaDE
Copy link

AlphaDE commented Dec 22, 2023

I support @iromeister comments, the web updater should warn and allow to completely ignore those directories. The issue is obviously longstanding and annoying for users.

@seraphyn
Copy link

You could put these directories into the folder data and set an alias on your web server to be delivered correctly

Merry Christmas

@AlphaDE
Copy link

AlphaDE commented Dec 22, 2023

@seraphyn I disagree... the /stats directory is created by ISPConfig in the web-root, it's not a question of an alias in the webserver config. Why is it so difficult to let the user ignore such a warning (and consequently exclude these directories from any further processing) instead of forcing him to move directories back and forth?

@seraphyn
Copy link

@seraphyn I disagree... the /stats directory is created by ISPConfig in the web-root, it's not a question of an alias in the webserver config. Why is it so difficult to let the user ignore such a warning (and consequently exclude these directories from any further processing) instead of forcing him to move directories back and forth?

I do not know, I just tried to help to find an option for you ;)

All the best

@kesselb
Copy link
Contributor

kesselb commented Dec 26, 2023

Why is it so difficult to let the user ignore such a warning (and consequently exclude these directories from any further processing) instead of forcing him to move directories back and forth?

A way to skip the unexpected file warning is not implemented.
The number of reports for this problem is low and therefore not on our roadmap.

@joshtrichards joshtrichards changed the title Updating NC 14.0.3 fails with other existing custom directories Support custom datadirectory (i.e. not called data) located in Nextcloud installation folder Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants