Merge pull request #558 from nextcloud/backport/556/stable28

[stable28] fix: Correctly check result of function
nextcloud · May 16, 2024 · 1cd7c63 · 1cd7c63
2 parents e6c47d8 + 7b9fd9a
commit 1cd7c63
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/index.php b/index.php
@@ -708,12 +708,12 @@ public function verifyIntegrity(): void {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');

diff --git a/lib/Updater.php b/lib/Updater.php
@@ -670,12 +670,12 @@ public function verifyIntegrity(): void {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');

diff --git a/updater.phar b/updater.phar