Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link clickable #4729

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Make link clickable #4729

merged 1 commit into from
Feb 18, 2025

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4672

  • General placeholder support for mentions - If the placeholder contains link, replace it with provided name and make it clickable.

circle_system_message

Clicking on the testing android2 should redirect to a website.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review February 17, 2025 07:44
@sowjanyakch sowjanyakch self-assigned this Feb 17, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 17, 2025
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the make_link_clickable branch from 214982c to ef95750 Compare February 18, 2025 08:56
@mahibi
Copy link
Collaborator

mahibi commented Feb 18, 2025

I added one minor change:
to get the current user, please use currentUserProvider whenever possible, instead userManager

@mahibi mahibi enabled auto-merge February 18, 2025 08:58
@mahibi
Copy link
Collaborator

mahibi commented Feb 18, 2025

/backport to stable-21.0

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4729-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 17702bb into master Feb 18, 2025
18 checks passed
@mahibi mahibi deleted the make_link_clickable branch February 18, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circles / Teams support
2 participants