Enhancement: Improve viewer integration for images #1624
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
commented
Feb 19, 2025
| @@ -263,3 +274,16 @@ export default { | |||
| padding-bottom: 4px; // to make it nice with the padding-top | |||
| } | |||
| </style> | |||
|
|
|||
| <style lang="scss"> | |||
| .preview [data-node-view-content] { | |||
blizzz
added
3. to review
enjeck
reviewed
Feb 21, 2025
Comment on lines
+243
to
+245
| const filePath = $img.src.match(/\/dav\/files\/(.+?)\/(.+)/)[2] | ||
| OCA.Viewer.open({ path: filePath }) | ||
| }) |
There was a problem hiding this comment.
Probably a n00b question: After uploading an image to files, how do I get a filepath that matches this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds viewer with lightbox for images that included into markdown.