fix: Export empty view array when exporting shared tables

[enjeck]

When a table is shared, the export code can't retrieve the views. So we return an empty array. Otherwise, we get the error:

  "message": "OCA\\Tables\\Model\\TableScheme::__construct(): Argument #4 ($view) must be of type array, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/tables/lib/Service/TableService.php on line 531 in file '/var/www/cloud.nextcloud.com/nextcloud/apps/tables/lib/Model/TableScheme.php' line 27",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:134.0) Gecko/20100101 Firefox/134.0",
  "version": "31.0.0.15",
  "exception": {
    "Exception": "Exception",
    "Message": "OCA\\Tables\\Model\\TableScheme::__construct(): Argument #4 ($view) must be of type array, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/tables/lib/Service/TableService.php on line 531 in file '/var/www/cloud.nextcloud.com/nextcloud/apps/tables/lib/Model/TableScheme.php' line 27",
    "Code": 0,
    "Trace": [

[enjeck]

When we do it this way, that means that when you export a shared table, the "views" array is empty. This is fine, right? @blizzz

[blizzz]

When we do it this way, that means that when you export a shared table, the "views" array is empty. This is fine, right? @blizzz

Empty array is fine, but if some or all of the views are accessible those should be exported all along.

[enjeck]

When we do it this way, that means that when you export a shared table, the "views" array is empty. This is fine, right? @blizzz

Empty array is fine, but if some or all of the views are accessible those should be exported all along.

I would expect getViews() to automatically do this, but it seems it doesn't

[blizzz]

When we do it this way, that means that when you export a shared table, the "views" array is empty. This is fine, right? @blizzz

Empty array is fine, but if some or all of the views are accessible those should be exported all along.

I would expect getViews() to automatically do this, but it seems it doesn't

Views are null, because they are not set yet.

tables/lib/Db/Table.php

Line 46 in 9a46561

* @method getViews(): array

is misleading, should also indicate that null is possible. $this->enhanceTable($table) would need to be called previously so that views are set (they still might be null without proper permissions –

tables/lib/Service/TableService.php

Lines 235 to 238 in 5e1ea60

	if (!$table->getIsShared() || $table->getOnSharePermissions()->manage) {
	// add the corresponding views if it is an own table, or you have table manage rights
	$table->setViews($this->viewService->findAll($table));
	}

).