fix(Import): DateTime import fixes #1545
Open
+73
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable0.8 |
- do not try to pass `null` to DateTimeImmutable as it would cause an Exception - be stricter on small letter-only values that might be turned into a DateTimeImmutable object because they match with timezone abbreviations - do not consider pure numbers a date Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/1518/import-date-handling
branch
from
28ae5e4 to
0e60292
Compare
blizzz
commented
Jan 17, 2025
| @@ -218,6 +218,32 @@ Feature: APIv1 | |||
| | import-from-ms365.xlsx | | |||
| | import-from-libreoffice.csv | | |||
|
|
|||
| @api1 @import @current | |||
There was a problem hiding this comment.
gotta remove @current again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullto DateTimeImmutable as it would cause an Exceptionfixes #1518