Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Templates): extend the tutorial table #1535

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 10, 2025

solves #1528

Screenshot_20250110_173841

Screenshot_20250110_173921

"Nextcloud" is variable with the instance name, as it should be. I have kept Nextcloud though in the link description towards the Tables wiki. Could remove it generally if it makes sense.

@blizzz blizzz added the 3. to review Waiting for reviews label Jan 10, 2025
@blizzz blizzz requested a review from juliusknorr January 10, 2025 16:40
@blizzz blizzz requested a review from enjeck as a code owner January 10, 2025 16:40
@blizzz blizzz force-pushed the enh/1528/example-contet branch from 0ab74ec to b3f9a72 Compare January 10, 2025 16:48
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, just a small comment on the view name ;)

@blizzz blizzz force-pushed the enh/1528/example-contet branch 2 times, most recently from fb56a01 to 237c2ad Compare January 10, 2025 20:19
@blizzz
Copy link
Member Author

blizzz commented Jan 10, 2025

tbc: taming cypress.

@blizzz
Copy link
Member Author

blizzz commented Jan 13, 2025

I think what we have here exposed now is the actual favorites bug, where the tests end up false-positively – #1350

@blizzz blizzz changed the base branch from main to fix/1350/favorites-cache January 13, 2025 12:40
@blizzz blizzz force-pushed the enh/1528/example-contet branch from 237c2ad to 91f7ac4 Compare January 13, 2025 12:40
@blizzz
Copy link
Member Author

blizzz commented Jan 13, 2025

Rebased to the favorutes-fix branch for testing.

@blizzz blizzz force-pushed the enh/1528/example-contet branch from 91f7ac4 to 10a21f3 Compare January 13, 2025 16:50
@blizzz
Copy link
Member Author

blizzz commented Jan 13, 2025

favorites is now done; share test is flaky. Waiting for #1542 before merging.

Base automatically changed from fix/1350/favorites-cache to main January 13, 2025 19:06
@blizzz blizzz force-pushed the enh/1528/example-contet branch from 10a21f3 to 88d9b89 Compare January 13, 2025 19:33
cypress/e2e/tables-export-csv.cy.js Outdated Show resolved Hide resolved
cypress/e2e/tables-favorite.cy.js Outdated Show resolved Hide resolved
cypress/support/commands.js Outdated Show resolved Hide resolved
lib/Service/TableService.php Show resolved Hide resolved
@blizzz blizzz force-pushed the enh/1528/example-contet branch 2 times, most recently from e6b68bb to 56bdef7 Compare January 15, 2025 09:54
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the enh/1528/example-contet branch from 56bdef7 to 637797f Compare January 15, 2025 11:03
@blizzz blizzz requested a review from enjeck January 15, 2025 11:04
@blizzz blizzz self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants