-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Templates): extend the tutorial table #1535
base: main
Are you sure you want to change the base?
Conversation
0ab74ec
to
b3f9a72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks, just a small comment on the view name ;)
fb56a01
to
237c2ad
Compare
tbc: taming cypress. |
I think what we have here exposed now is the actual favorites bug, where the tests end up false-positively – #1350 |
237c2ad
to
91f7ac4
Compare
Rebased to the favorutes-fix branch for testing. |
91f7ac4
to
10a21f3
Compare
favorites is now done; share test is flaky. Waiting for #1542 before merging. |
10a21f3
to
88d9b89
Compare
e6b68bb
to
56bdef7
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
56bdef7
to
637797f
Compare
solves #1528
"Nextcloud" is variable with the instance name, as it should be. I have kept Nextcloud though in the link description towards the Tables wiki. Could remove it generally if it makes sense.