Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column types for IPv4 and IPv6 addresses, compatible with both text and numeric filters, thanks to natural sort #1097

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5d2b5c0
sort column types
kirisakow May 19, 2024
7ba4a61
add ColumnType TextIPv4Address
kirisakow May 19, 2024
0923891
add ColumnType TextIPv6Address
kirisakow May 19, 2024
6465baf
fix: column type-subtype value may not contain more than one hyphen
kirisakow May 19, 2024
5c4519d
add radio buttons for Create Column modal dialog
kirisakow May 19, 2024
c479bc6
l10n: add placeholders for labels "IPv4 address" and "IPv6 address"
kirisakow May 19, 2024
a6bdf61
add column type partials
kirisakow May 20, 2024
bb2b5e2
rename as per the declared column types
kirisakow May 20, 2024
820a0fc
use built-in JS func `localeCompare` to compare two strings.
kirisakow May 21, 2024
25d4a8e
update magic fields
kirisakow May 21, 2024
090cec2
rename class name: append `Column` suffix
kirisakow May 21, 2024
8634e2c
update `columnParser.js`
kirisakow May 21, 2024
a7a9ee5
update `EditColumn.vue`
kirisakow May 21, 2024
4dc5a90
update `ColumnFormComponent.vue`
kirisakow May 21, 2024
6873cc9
fix: CSS-compatible comments syntax
kirisakow May 21, 2024
11db295
add row type partials
kirisakow May 21, 2024
e8acab0
sort imports
kirisakow May 21, 2024
69baf81
update `CreateColumn.vue`
kirisakow May 21, 2024
31e5bde
sort imports
kirisakow May 21, 2024
1d6cde9
fix: undo a misfocused search pattern that was baked in to the commit…
kirisakow May 21, 2024
6609fbc
fix: `Module not found: Error`
kirisakow May 22, 2024
81ecfce
fix: `Error: Form ... does no exist` by changing subtype value declar…
kirisakow May 22, 2024
2f612bd
fix: `Error: Form ... does no exist`:
kirisakow May 22, 2024
6c84f3b
fix: default component name
kirisakow May 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update magic fields
kirisakow authored May 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 25d4a8e1729d0ed46fbf1becb9ba0ff1a230c7fe
4 changes: 2 additions & 2 deletions src/shared/components/ncTable/mixins/magicFields.js
Original file line number Diff line number Diff line change
@@ -34,14 +34,14 @@ export const MagicFields = {
id: 'me',
label: t('tables', 'Me (user ID)'),
icon: 'icon-user',
goodFor: [ColumnTypes.TextLine, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich, ColumnTypes.TextLink],
goodFor: [ColumnTypes.TextLine, ColumnTypes.TextIPv4Address, ColumnTypes.TextIPv6Address, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich, ColumnTypes.TextLink],
replace: getCurrentUser()?.uid,
}),
MyName: new MagicField({
id: 'my-name',
label: t('tables', 'Me (name)'),
icon: 'icon-user',
goodFor: [ColumnTypes.TextLine, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich, ColumnTypes.TextLink],
goodFor: [ColumnTypes.TextLine, ColumnTypes.TextIPv4Address, ColumnTypes.TextIPv6Address, ColumnTypes.Selection, ColumnTypes.SelectionMulti, ColumnTypes.TextRich, ColumnTypes.TextLink],
replace: getCurrentUser()?.displayName,
}),
Checked: new MagicField({