-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chat): Add the mention id to parameters for easier editing #14270
Conversation
Is there any reason to not always wrap a mention in quotes? Currently we only do it if there's a "/" or whitespace, but does it really matter? |
IIRC it works always so its save to do it always, but e.g. on our instance since we use "first name", I always type it directly manually without waiting for the autocomplete |
a2f2504
to
ee0074e
Compare
/backport to stable31 |
when proxying such a message I guess the server should extend the attribute if it was missing? |
Would be nice, if itβs not too much work. Then it consistent across all clients. |
Can't add it to OpenAPI docs as the type then conflicts with the RichObject Definitions and Psalm complains |
/backport to stable31 |
7a93818
to
8fba13f
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
8fba13f
to
a2ed72a
Compare
π οΈ API Checklist
π§ Tasks
π Checklist
docs/
has been updated or is not required