Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RTL support in call view #14247

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: RTL support in call view #14247

merged 1 commit into from
Jan 30, 2025

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🪺 Next Major (32) milestone Jan 29, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy January 29, 2025 14:16
@DorraJaouad DorraJaouad self-assigned this Jan 29, 2025
Antreesy
Antreesy reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to revert 05ba741

src/components/CallView/shared/PresenterOverlay.vue Outdated Show resolved Hide resolved
src/components/CallView/Grid/Grid.vue Show resolved Hide resolved
Antreesy
Antreesy approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough

Antreesy

This comment was marked as duplicate.

Sign in to view

Antreesy

This comment was marked as duplicate.

Sign in to view

Antreesy

This comment was marked as duplicate.

Sign in to view

@DorraJaouad DorraJaouad force-pushed the fix/noid/rtl-call-view branch from 1820833 to 3842d4c Compare January 30, 2025 15:00
@DorraJaouad @Antreesy
fix: RTL support in call view
d19a764 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/rtl-call-view branch from 3842d4c to d19a764 Compare January 30, 2025 15:42
@Antreesy Antreesy enabled auto-merge January 30, 2025 15:42
@Antreesy
Copy link
Contributor

/backport to stable31

@Antreesy Antreesy merged commit 0a6162d into main Jan 30, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/rtl-call-view branch January 30, 2025 15:45
@backportbot backportbot bot mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: RTL ⬅️
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@DorraJaouad @Antreesy