fix(desktop): change "reload page" messages to "restart app" #14181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
2. developing
bug
feature: frontend 🖌️
ShGKme
force-pushed
the
desktop/reload-the-page-messages
branch
from
e8dbf87 to
0707fb4
Compare
| @@ -136,7 +137,7 @@ export async function setRemoteCapabilities(joinRoomResponse: JoinRoomFullRespon | |||
| patchTokenMap(joinRoomResponse.data.ocs.data) | |||
|
|
|||
| // As normal capabilities update, requires a reload to take effect | |||
| showError(t('spreed', 'Nextcloud Talk Federation was updated, please reload the page'), { | |||
| showError(t('spreed', 'Nextcloud Talk Federation was updated.') + '\n' + messagePleaseReload, { | |||
There was a problem hiding this comment.
Something for later, but this should say something like:
"Nextcloud Talk was updated on the federated server."
And we should have a look if we can make sure it does not yield when you open such a conversation the first time
There was a problem hiding this comment.
Another point regarding \n: we discussed with Dorra, if toasts width should be limited upstream to ~750px (80 characters per line is recommended by W3C standard)?
There was a problem hiding this comment.
if toasts width should be limited
If a toast contains a long complex sentence, it probably shouldn't be a toast, but a part of UI
nickvergessen
approved these changes
Jan 23, 2025
2 tasks
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
desktop/reload-the-page-messages
branch
from
0707fb4 to
5e9eaca
Compare
|
|
/backport! to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist