fix: validate account properties as a repair step #50985
Merged
+271
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
artonge,
skjnldsv and
sorbaugh
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
susnux
force-pushed
the
fix/account-property-validation
branch
from
d47f311 to
3dfafc9
Compare
come-nc
reviewed
Feb 24, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
susnux
force-pushed
the
fix/account-property-validation
branch
from
3dfafc9 to
6016ebc
Compare
come-nc
reviewed
Feb 24, 2025
susnux
dismissed
juliusknorr’s stale review
Resolved by migrating to background job
come-nc
approved these changes
Feb 24, 2025
sorbaugh
approved these changes
Feb 24, 2025
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step, `ValidateAccountProperties` which validates and sanitizes all account properties. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…nd job Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/account-property-validation
branch
from
0a68085 to
e3af27b
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/50985/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 08d33a9f 575222b5 e3af27b2
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50985/stable29Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
ValidatePhoneNumberfrom Nextcloud 21 with a new repair step,ValidateAccountPropertieswhich validates and sanitizes all account properties.It ensures all existing values are valid (now that we also validate twitter and fediverse it could lead to issues like the reported one).
Checklist