Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user_ldap): sync users even when no display name is set #50984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eyJhb
Copy link

@eyJhb eyJhb commented Feb 23, 2025

Summary

Removes the check for display name when doing batchApplyUserAttributes, as that is no longer a bug anymore (it was first introduced in owncloud/core#20804 ). This works well in combination with #46114 , which also fixes the enforcement of display name + it fixes logic that was applied for both users and groups, even though it only applied to groups.

I think this PR ,as well as the previous linked one, we will be able to close this issue #39751 , which is largely misconfiguration, however, there is no need for enforcing display name anymore.

Opening this in the hope of getting someone smarter to say if this is a good/bad idea. Spent most of a day debugging this, and the codebase is still very large to navigate for me.

I'm thinking @come-nc will have some insight this area :) Hopefully tagging is not frowned upon.

TODO

Checklist

Signed-off-by: eyJhb <eyjhbb@gmail.com>
@susnux susnux added bug 3. to review Waiting for reviews labels Feb 23, 2025
@susnux susnux added this to the Nextcloud 32 milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
2 participants