fix: only do cache copy in updater if the parent folder should be in cache #49695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
artonge,
skjnldsv and
come-nc
and removed request for
a team
This was referenced Dec 6, 2024
artonge
approved these changes
Dec 9, 2024
come-nc
approved these changes
Dec 9, 2024
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#48651 broke moving encrypted files to encrypted groupfolders when not using object store (see the failing cypress run) because the
/files_encryption/...folders are intentionally excluded from the cache. So that parent folder of the target of the copy is not in cache, makingcopyFromCachefail.This change makes the updater match the old behavior[1] by not updating the cache if the parent folder isn't in the cache (and is excluded from scanning).
[1]: the cache updates for copies where previously handled by
Updater::updatewhich just callsscanand thus ignores such excluded paths