Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix ServiceWorker scope when Nextcloud installed in subfolder #49694

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Dec 6, 2024

Summary

  1. Install Nextcloud into subfolder, e.g. nc
  2. Open files app

Expected result: ServiceWorker registered only for subfolder
Actual result: ServiceWorker registered for whole domain

🔍 Screenshot after fix

image

Checklist

@Koc Koc requested a review from skjnldsv as a code owner December 6, 2024 16:32
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the bugfix/fix-service-worker-scope branch from 972a601 to 2e1cd23 Compare December 6, 2024 16:33
@Koc
Copy link
Contributor Author

Koc commented Dec 6, 2024

/backport to stable30

@Koc
Copy link
Contributor Author

Koc commented Dec 6, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv requested a review from artonge December 11, 2024 07:41
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Dec 11, 2024
@skjnldsv skjnldsv merged commit 94fa2cf into master Dec 11, 2024
120 checks passed
@skjnldsv skjnldsv deleted the bugfix/fix-service-worker-scope branch December 11, 2024 09:26
@provokateurin
Copy link
Member

provokateurin commented Dec 18, 2024

I think this is broken, we now register a service worker for each path:
image
There only should be one service worker, otherwise we will consume a lot of resources after navigating through a few folders and so on.

@provokateurin
Copy link
Member

Fix is at #49917

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants