fix: smb: don't fail hard if we can't load acls for a file #49288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
ArtificialOwl,
nfebe and
come-nc
and removed request for
a team
come-nc
reviewed
Nov 14, 2024
|
the acl check only hides folders that users don't have access to from the file listing. Any attempt to enter the folder when the acl check is disabled/not working will result in the user seeing an empty folder. |
And seeing the folder name is not already an information leak? |
|
Windows has the same behavior of showing the non-readable folders |
come-nc
approved these changes
Nov 26, 2024
artonge
approved these changes
Dec 4, 2024
|
/backport to stable30 |
|
/backport to stable29 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we log the error and behave as if no ACL was found.