Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no refresh on existing blurhash #42682

Closed
wants to merge 1 commit into from
Closed

no refresh on existing blurhash #42682

wants to merge 1 commit into from

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jan 10, 2024 •
edited
Loading

  • store current etag when generating blurhash
  • compare etag if previous blurhash exists
  • ignore etag if run from ./occ files:scan --generate-metadata blurhash

@ArtificialOwl
no refresh on existing blurhash
5b35658 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl added this to the Nextcloud 29 milestone Jan 10, 2024
@ArtificialOwl ArtificialOwl requested review from a team, blizzz, nfebe and sorbaugh and removed request for a team January 10, 2024 15:23
@ArtificialOwl
Copy link
Member Author

followup of #41044

@ArtificialOwl
Copy link
Member Author

closing as this will be implemented directly in the metadata API: #42707

@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
@skjnldsv skjnldsv deleted the enh/noid/no-refresh-blurhash branch March 14, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtificialOwl @skjnldsv