Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theming): Adjust high contrast theme to fulfill WCAG AAA text contrast #42438

Merged
merged 1 commit into from
Dec 27, 2023
Merged

fix(theming): Adjust high contrast theme to fulfill WCAG AAA text contrast #42438

merged 1 commit into from
Dec 27, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 22, 2023

Summary

The last one of the themes to adjust. This adjusts the light high contrast theme to fulfill WCAG AAA text contrast criteria.

Checklist

@susnux susnux added 3. to review Waiting for reviews accessibility labels Dec 22, 2023
@susnux susnux force-pushed the fix/make-high-contrast-theme-really-high-contrast branch from f013082 to 22e0d42 Compare December 22, 2023 00:20
@susnux
Copy link
Contributor Author

susnux commented Dec 22, 2023

/backport to stable28

@susnux @emoral435
fix(theming): Adjust high contrast theme to fulfill WCAG AAA text con…
a782d6f 
…trast

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@emoral435 emoral435 force-pushed the fix/make-high-contrast-theme-really-high-contrast branch from 22e0d42 to a782d6f Compare December 22, 2023 20:05
@emoral435 emoral435 enabled auto-merge December 22, 2023 20:05
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 27, 2023
@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Dec 27, 2023
@emoral435 emoral435 merged commit fc7e643 into master Dec 27, 2023
49 checks passed
@emoral435 emoral435 deleted the fix/make-high-contrast-theme-really-high-contrast branch December 27, 2023 09:09
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 27, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@emoral435 emoral435 emoral435 approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @skjnldsv @emoral435