From 593a2349c1683898239f07c073b9d43787cf8e2d Mon Sep 17 00:00:00 2001 From: fenn-cs Date: Mon, 11 Dec 2023 22:24:32 +0100 Subject: [PATCH 1/5] Rephrase unified search helper text Signed-off-by: fenn-cs --- core/src/views/UnifiedSearchModal.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/views/UnifiedSearchModal.vue b/core/src/views/UnifiedSearchModal.vue index 1d6b138fdb353..7ea8381d95418 100644 --- a/core/src/views/UnifiedSearchModal.vue +++ b/core/src/views/UnifiedSearchModal.vue @@ -216,7 +216,7 @@ export default { return { show: isEmptySearch || hasNoResults, - text: this.searching && hasNoResults ? t('core', 'Searching …') : (isEmptySearch ? t('core', 'Start typing in search') : t('core', 'No matching results')), + text: this.searching && hasNoResults ? t('core', 'Searching …') : (isEmptySearch ? t('core', 'Start typing to search') : t('core', 'No matching results')), icon: MagnifyIcon, } }, From 44c689ac1ef307ad01780870d3cc2736701c48b3 Mon Sep 17 00:00:00 2001 From: fenn-cs Date: Mon, 11 Dec 2023 22:43:53 +0100 Subject: [PATCH 2/5] Unified search: update people select with API calls On change/input from user which has the effect of filtering, we want to send the query to the API to obtained fresh results, based on the databased on not just preloaded contacts. Signed-off-by: fenn-cs --- core/src/components/UnifiedSearch/SearchableList.vue | 4 ++++ core/src/views/UnifiedSearchModal.vue | 2 ++ 2 files changed, 6 insertions(+) diff --git a/core/src/components/UnifiedSearch/SearchableList.vue b/core/src/components/UnifiedSearch/SearchableList.vue index 43f7ace1b64ac..33f45d062661f 100644 --- a/core/src/components/UnifiedSearch/SearchableList.vue +++ b/core/src/components/UnifiedSearch/SearchableList.vue @@ -32,6 +32,7 @@ :label="labelText" trailing-button-icon="close" :show-trailing-button="searchTerm !== ''" + @update:value="searchTermChanged" @trailing-button-click="clearSearch"> @@ -126,6 +127,9 @@ export default { this.clearSearch() this.opened = false }, + searchTermChanged(term) { + this.$emit('search-term-change', term) + }, }, } diff --git a/core/src/views/UnifiedSearchModal.vue b/core/src/views/UnifiedSearchModal.vue index 7ea8381d95418..76a4486d02168 100644 --- a/core/src/views/UnifiedSearchModal.vue +++ b/core/src/views/UnifiedSearchModal.vue @@ -55,6 +55,7 @@