-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Adjust ID for skip content buttons #42419
Conversation
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main content may have ids:
#app-content-vue
in Vue apps from rendered as NcAppContent, usually used in full Vue apps with rendered asNcContent
with navigation and sidebar (Talk, Photos, Activity, Users settings, Apps settings) and in Files (there isNcAppContent
but noNcContent
).- Set in Template via
id-app-content
. By default, it is#app-content
for user and#content
for public, but can be custom set viaid-app-content
property. Used by not full Vue apps (notNcContent
apps), for example, any page in Personal or Admin settings, Help, Public share.
Skip links always uses the ID from p.2.
This PR fixes the issue for Files app but doesn't fix the issue in general. For example, Photos app, Activity app.
I think we should have a solution that fixes Skip links in a common way, otherwise we need to fix it in each app separately and have no control over it.
I know this is just the first quick fix. I currently prepare a more general fix on the vue library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A common solution from @nextcloud/vue
will work for general apps like Photos, Activity or Talk.
This PR is needed because Files app has more complex mounting with NcAppContent
but without NcContent
by manual mounting of content, navigation, and sidebar.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
008f3aa
to
59c982f
Compare
/backport to stable28 |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
As we now use Vue the ID needs to be adjusted.
Checklist