-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theming): Adjust dark high contrast to fulfill WCAG 2.1 AAA contrast #42329
Conversation
ee63ecd
to
734f0dc
Compare
b2ac6de
to
11434aa
Compare
734f0dc
to
8dee78f
Compare
11434aa
to
5296045
Compare
8dee78f
to
ae12a73
Compare
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks!
This comment was marked as resolved.
This comment was marked as resolved.
5296045
to
81775b2
Compare
@JuliaKirschenheuter I adjusted all themes for the |
That works now, thanks a lot! |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…put border colors Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
81775b2
to
acfb8ef
Compare
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable28 |
Summary
This adds high contrast support for the theming util and unit tests and adjust the high contrast dark theme to fulfill WCAG 2.1 AAA color contrast for text.
Checklist