fix(url): correct WOPI settings URL to prevent duplicate nextcloud
#4461
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codewithvk
force-pushed
the
private/codewithvk/url_issue
branch
4 times, most recently
from
87c828c to
f235e9c
Compare
codewithvk
force-pushed
the
private/codewithvk/url_issue
branch
from
f235e9c to
565535f
Compare
juliusknorr
reviewed
Feb 10, 2025
codewithvk
force-pushed
the
private/codewithvk/url_issue
branch
from
565535f to
40a9df1
Compare
codewithvk
force-pushed
the
private/codewithvk/url_issue
branch
3 times, most recently
from
40a9df1 to
9f61c3a
Compare
|
CI Irrelevant of this PR, @juliusknorr @elzody Could you please review this PR? |
pedropintosilva
force-pushed
the
private/codewithvk/url_issue
branch
from
9f61c3a to
04d6ce7
Compare
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
codewithvk
force-pushed
the
private/codewithvk/url_issue
branch
from
04d6ce7 to
49df6d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
getCallbackBaseUrl()withgetBaseUrl()to ensure the correct WOPI settings URL. This prevents the issue where/nextcloudappears twice in the generated URL.prev URL : http://localhost/nextcloud/nextcloud/index.php/apps/richdocuments/wopi/settings
now it should be: http://localhost/nextcloud/index.php/apps/richdocuments/wopi/settings