Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: portable document format --> pdf #4442

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: portable document format --> pdf #4442

merged 1 commit into from
Feb 4, 2025

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Feb 4, 2025 •
edited
Loading

Summary

Change Save as Portable Document Format (.pdf) to Save as PDF (.pdf) which is less verbose and more in line with how most users refer to the format.

Before

image

After

image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody
fix: portable document format --> pdf
4a1e749 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody added the 3. to review Ready to be reviewed label Feb 4, 2025
@elzody elzody requested a review from jancborchardt February 4, 2025 18:16
@elzody elzody self-assigned this Feb 4, 2025
@elzody elzody requested a review from juliusknorr as a code owner February 4, 2025 18:17
@elzody
Copy link
Contributor Author

elzody commented Feb 4, 2025

/backport to stable31

@juliusknorr juliusknorr merged commit 048cc2e into main Feb 4, 2025
68 checks passed
@juliusknorr juliusknorr deleted the fix/save-as-pdf-file-action-convert branch February 4, 2025 20:33
@backportbot backportbot bot mentioned this pull request Feb 4, 2025
Merged
jancborchardt
jancborchardt reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @elzody! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@elzody elzody

Labels
3. to review Ready to be reviewed
Projects
📝 Office team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Save as Portable Document Format" is unnecessarily verbose
3 participants
@elzody @jancborchardt @juliusknorr