Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Classify): allow specifying user/path #905 #1225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions lib/Command/Classify.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use OCA\Recognize\Service\TagManager;
use OCP\Files\Config\ICachedMountInfo;
use OCP\Files\Config\IUserMountCache;
use OCP\Files\IRootFolder;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Exception\ExceptionInterface;
use Symfony\Component\Console\Input\ArrayInput;
Expand All @@ -30,10 +31,13 @@ class Classify extends Command {
/** @var array<string, Classifier> */
private array $classifiers = [];

protected IRootFolder $rootFolder;

public function __construct(
private StorageService $storageService,
private TagManager $tagManager,
private Logger $logger,
IRootFolder $rootFolder,
ImagenetClassifier $imagenet,
ClusteringFaceClassifier $faces,
MovinetClassifier $movinet,
Expand All @@ -43,6 +47,7 @@ public function __construct(
private ClearBackgroundJobs $clearBackgroundJobs,
) {
parent::__construct();
$this->rootFolder = $rootFolder;
$this->classifiers[ImagenetClassifier::MODEL_NAME] = $imagenet;
$this->classifiers[ClusteringFaceClassifier::MODEL_NAME] = $faces;
$this->classifiers[MusicnnClassifier::MODEL_NAME] = $musicnn;
Expand All @@ -57,8 +62,10 @@ public function __construct(
*/
protected function configure() {
$this->setName('recognize:classify')
->setDescription('Classify all files with the current settings in one go (will likely take a long time)')
->addOption('retry', null, InputOption::VALUE_NONE, "Only classify untagged images");
->setDescription('Classify all files with the current settings in one go (will likely take a long time).')
->addOption('retry', null, InputOption::VALUE_NONE, "Only classify untagged images.")
->addOption('user', 'u', InputOption::VALUE_REQUIRED, "Only classify files for the given user.", null)
->addOption('path', 'p', InputOption::VALUE_REQUIRED, "Only classify files for the given path. Applicable only with the --user option.", null);
}

/**
Expand Down Expand Up @@ -86,6 +93,29 @@ protected function execute(InputInterface $input, OutputInterface $output): int

$processedTag = $this->tagManager->getProcessedTag();

$userFilter = $input->getOption('user');
$pathFilter = $input->getOption('path');

$pathMatcher = null;

if ($userFilter === null && $pathFilter !== null) {
$this->logger->warning('Path filter is set, but no user filter is set. Ignoring path filter.');
unset($pathFilter);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

} else if ($userFilter !== null) {
$pathMatcher = '/' . $userFilter;

if ($pathFilter !== null) {
if (!str_starts_with($pathFilter, '/')) {
$pathFilter = '/' . $pathFilter;
}
$pathMatcher .= '/files' . $pathFilter;
}
}

if ($pathMatcher !== null) {
$this->logger->info('Matching files for path: ' . $pathMatcher);
}

foreach ($this->storageService->getMounts() as $mount) {
$this->logger->info('Processing storage ' . $mount['storage_id'] . ' with root ID ' . $mount['override_root']);

Expand All @@ -107,6 +137,20 @@ protected function execute(InputInterface $input, OutputInterface $output): int
MusicnnClassifier::MODEL_NAME => [],
];
foreach ($this->storageService->getFilesInMount($mount['storage_id'], $mount['override_root'], $models, $lastFileId) as $file) {

if ($pathMatcher !== null) {
Copy link
Member

@marcelklehr marcelklehr Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go through all files of the nextcloud instance even if only a single folder is given via the parameter. If we check the users of the mounts the we got in line 123 we can short circuit mounts that can not be accessed by the user that was requested. I hope that's understandable :) This way we can avoid a lot of needless db queries :)

$actualFile = $this->rootFolder->getById($file['fileid']);
if ($actualFile[0] !== null) {
$path = $actualFile[0]->getPath();

if (!str_starts_with($path, $pathMatcher)) {
continue;
}
$this->logger->info('Matching file path: ' . $actualFile[0]->getPath());
} else {
continue;
}
}
$i++;
$lastFileId = $file['fileid'];
$queueFile = new QueueFile();
Expand Down