Skip to content

Commit

Permalink
release.yml: Disable broken image builds
Browse files Browse the repository at this point in the history
Signed-off-by: Tobias Knöppler <6317548+theCalcaholic@users.noreply.github.com>
  • Loading branch information
theCalcaholic committed Jan 20, 2023
1 parent 802ffcc commit 99a608a
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 28 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ jobs:
docker push "thecalcaholic/ncp-internal-${ARCH?}:${{ github.run_id }}-testing"
update-test:
# TODO: Fix update-test for armhf
# The issues are originating in a seemingly bug in apache2 that only occurs in the GH action and only
# if a docker volume or directory is mounted to /data.
# In this configuration, apache will serve the default placeholder page instead of the sites configured in ncp.
if: ${{ inputs.arch != 'armhf' }}
needs:
- build
Expand Down
58 changes: 30 additions & 28 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@ jobs:
board_name: RaspberryPi
secrets: inherit

# TODO: Fix 32bit armbian images
odroidxu4:
if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
# if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
if: ${{ false }}
uses: ./.github/workflows/build-sd-images.yml
with:
git_ref: "${{ inputs.git_ref || github.head_ref || github.ref_name }}"
Expand All @@ -111,8 +113,10 @@ jobs:
board_id: rock64
board_name: Rock64
secrets: inherit
# TODO: Fix 32bit armbian images
bananapi:
if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
#if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
if: ${{ false }}
uses: ./.github/workflows/build-sd-images.yml
with:
git_ref: "${{ inputs.git_ref || github.head_ref || github.ref_name }}"
Expand Down Expand Up @@ -170,19 +174,18 @@ jobs:
dry_run: ${{ (!inputs.release && github.event_name == 'workflow_dispatch') || github.ref_type != 'tag' || !(github.ref_protected || startsWith(github.ref, 'refs/tags/v')) }}
secrets: inherit

# TODO: Fix 32bit armbian images
# odroidxu4-release:
# needs:
# - odroidxu4
# - github-release
# if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
# uses: ./.github/workflows/publish-image.yml
# with:
# git_ref: "${{ inputs.git_ref || github.head_ref || github.ref_name }}"
# artifact_id: "${{ needs.odroidxu4.outputs.artifact_name }}"
# artifact_file: "${{ needs.odroidxu4.outputs.artifact_file }}"
# dry_run: ${{ (!inputs.release && github.event_name == 'workflow_dispatch') || github.ref_type != 'tag' || !(github.ref_protected || startsWith(github.ref, 'refs/tags/v')) }}
# secrets: inherit
odroidxu4-release:
needs:
- odroidxu4
- github-release
if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
uses: ./.github/workflows/publish-image.yml
with:
git_ref: "${{ inputs.git_ref || github.head_ref || github.ref_name }}"
artifact_id: "${{ needs.odroidxu4.outputs.artifact_name }}"
artifact_file: "${{ needs.odroidxu4.outputs.artifact_file }}"
dry_run: ${{ (!inputs.release && github.event_name == 'workflow_dispatch') || github.ref_type != 'tag' || !(github.ref_protected || startsWith(github.ref, 'refs/tags/v')) }}
secrets: inherit
rockpro64-release:
needs:
- rockpro64
Expand All @@ -207,19 +210,18 @@ jobs:
artifact_file: "${{ needs.rock64.outputs.artifact_file }}"
dry_run: ${{ (!inputs.release && github.event_name == 'workflow_dispatch') || github.ref_type != 'tag' || !(github.ref_protected || startsWith(github.ref, 'refs/tags/v')) }}
secrets: inherit
# TODO: Fix 32bit armbian images
# bananapi-release:
# needs:
# - bananapi
# - github-release
# if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
# uses: ./.github/workflows/publish-image.yml
# with:
# git_ref: "${{ inputs.git_ref || github.head_ref || github.ref_name }}"
# artifact_id: "${{ needs.bananapi.outputs.artifact_name }}"
# artifact_file: "${{ needs.bananapi.outputs.artifact_file }}"
# dry_run: ${{ (!inputs.release && github.event_name == 'workflow_dispatch') || github.ref_type != 'tag' || !(github.ref_protected || startsWith(github.ref, 'refs/tags/v')) }}
# secrets: inherit
bananapi-release:
needs:
- bananapi
- github-release
if: ${{ inputs.sd-images || github.event_name != 'workflow_dispatch' }}
uses: ./.github/workflows/publish-image.yml
with:
git_ref: "${{ inputs.git_ref || github.head_ref || github.ref_name }}"
artifact_id: "${{ needs.bananapi.outputs.artifact_name }}"
artifact_file: "${{ needs.bananapi.outputs.artifact_file }}"
dry_run: ${{ (!inputs.release && github.event_name == 'workflow_dispatch') || github.ref_type != 'tag' || !(github.ref_protected || startsWith(github.ref, 'refs/tags/v')) }}
secrets: inherit
odroidhc4-release:
needs:
- odroidhc4
Expand Down

0 comments on commit 99a608a

Please sign in to comment.