-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_framework): Support blurhashes in NeonImages #2100
Conversation
06e6528
to
d449910
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
==========================================
- Coverage 30.22% 29.97% -0.26%
==========================================
Files 258 258
Lines 84835 84879 +44
==========================================
- Hits 25640 25441 -199
- Misses 59195 59438 +243
*This pull request uses carry forward flags. Click here to find out more.
|
I have not tested this code yet but looking at the code I'm wondering if we should also show the blurhash when an error occurred? |
Hm yeah that might make sense, as we at least show something to the user and the user also knows that the image /hasn't/wasn't fully loaded (yet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I should probably still change that for errors the blurhash will be shown? |
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Yes please |
d449910
to
0189240
Compare
Closes #1583
I could remove the dropping of the non-existent prop here and make a separate PR that we merge right before we make a new breaking release.
Talk doesn't add the blurhash metadata yet for images in chat messages, but I already filed an issue for that: nextcloud/spreed#12351
Testing this on the dev container is not so easy because the metadata isn't populated due to the crons not working as intended. To trigger it manually for a file use
./occ metadata:get --refresh --reset --as-array
.