Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include circles to acl #3551

Merged
merged 5 commits into from
Feb 6, 2025
Merged

include circles to acl #3551

merged 5 commits into from
Feb 6, 2025

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jan 23, 2025 •
edited by icewind1991
Loading

This adds Teams to the ACL management:

  • search will now returns Teams and Teams' members so that Circles can be added to the list of ACL Manager in the admin settings of the app,
  • ACL rights about Teams and Teams' members can be set in the right panel when navigating a groupfolders' files,
  • ACL set regarding a Teams and Teams' members are applied to files and folders.

Missing front-end:

  • In the admin part, while the Teams' member are displayed, the Teams are missing in the dropdown list when adding ACL Manager. This is due to the fact that the data stored behind the array key 'circles' are not managed by the javascript.
  • In the admin part, when displaying a Team, it is shown as 'Group' instead of 'Team'
  • In the Files' right panel, while the Teams' member are displayed, the Teams are not in the dropdown list when adding ACL Permissions.

@sorbaugh sorbaugh requested a review from icewind1991 January 23, 2025 11:15
@ArtificialOwl ArtificialOwl force-pushed the feat/noid/acl-circles branch 3 times, most recently from 3b04873 to fafb1fa Compare January 24, 2025 10:43
@AndyScherzinger AndyScherzinger added enhancement 2. developing Items that are currently under development feature: acl Items related to the groupfolders ACL or "Advanced Permissions" labels Jan 25, 2025
@sorbaugh sorbaugh requested a review from icewind1991 February 3, 2025 10:11
icewind1991
icewind1991 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for @ArtificialOwl's part

ArtificialOwl and others added 2 commits February 5, 2025 17:31
@ArtificialOwl @icewind1991
include circles to acl
1e3b6df 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@icewind1991
fix: show teams in acl manager settings
f2028d7 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the feat/noid/acl-circles branch from ca1ba21 to 53a90cb Compare February 5, 2025 16:31
skjnldsv
skjnldsv approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane 💅

@icewind1991
fix: make canManageACL work with circles
5e1530e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: show teams in acl ui
bd7750e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the feat/noid/acl-circles branch from 53a90cb to bd7750e Compare February 6, 2025 13:59
@icewind1991
chore: js lint
84efc70 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 merged commit 973ae92 into master Feb 6, 2025
51 checks passed
@icewind1991 icewind1991 deleted the feat/noid/acl-circles branch February 6, 2025 15:14
@icewind1991
Copy link
Member

/backport to stable31

@icewind1991
Copy link
Member

/backport to stable30

@backportbot backportbot bot mentioned this pull request Feb 6, 2025
Merged
2 tasks
@backportbot backportbot bot mentioned this pull request Feb 6, 2025
Merged
2 tasks
@icewind1991
Copy link
Member

I'll do further backports from the 30 backport to reduce the conflict resolution work

@icewind1991
Copy link
Member

icewind1991 commented Feb 12, 2025 •
edited
Loading

29: #3605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
2. developing Items that are currently under development enhancement feature: acl Items related to the groupfolders ACL or "Advanced Permissions"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArtificialOwl @icewind1991 @AndyScherzinger @skjnldsv