dont remove trash item from cache if the delete failed

nextcloud · Sep 25, 2019 · ac89a22 · ac89a22
1 parent 7e68502
commit ac89a22
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/Trash/TrashBackend.php b/lib/Trash/TrashBackend.php
@@ -115,7 +115,9 @@ public function removeItem(ITrashItem $item) {
 		if ($node === null) {
 			throw new NotFoundException();
 		}
-		$node->getStorage()->unlink($node->getInternalPath());
+		if ($node->getStorage()->unlink($node->getInternalPath()) === false) {
+			throw new \Exception('Failed to remove item from trashbin');
+		}
 		$node->getStorage()->getCache()->remove($node->getInternalPath());
 		if ($item->isRootItem()) {
 			$this->trashManager->removeItem($folderId, $item->getName(), $item->getDeletedTime());