Fix stubs and fix psalm spotted issues throughout the code

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud · Dec 21, 2023 · 7554e63 · 7554e63
1 parent c03189f
commit 7554e63
Show file tree

Hide file tree

Showing 8 changed files with 813 additions and 323 deletions.
diff --git a/lib/Command/ListCommand.php b/lib/Command/ListCommand.php
@@ -35,6 +35,7 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ListCommand extends Base {
+	/** @var array<int,string> */
 	public const PERMISSION_NAMES = [
 		Constants::PERMISSION_READ => 'read',
 		Constants::PERMISSION_UPDATE => 'write',
@@ -132,7 +133,7 @@ private function permissionsToString(int $permissions): string {
 		if ($permissions === 0) {
 			return 'none';
 		}
-		return implode(', ', array_filter(self::PERMISSION_NAMES, function ($possiblePermission) use ($permissions) {
+		return implode(', ', array_filter(self::PERMISSION_NAMES, function (int $possiblePermission) use ($permissions) {
 			return $possiblePermission & $permissions;
 		}, ARRAY_FILTER_USE_KEY));
 	}

diff --git a/lib/Controller/FolderController.php b/lib/Controller/FolderController.php
@@ -88,8 +88,8 @@ private function filterNonAdminFolder(array $folder): ?array {
 	}
 
 	/**
-	 * @param array{id: mixed, mount_point: mixed, groups: array<string, array{displayName: string, type: string, permissions: integer}>, quota: int, size: int, acl: bool} $folder
-	 * @return array{id: mixed, mount_point: mixed, groups:array<string, integer>, group_details: array<empty, empty>|mixed, quota: int, size: int, acl: bool}
+	 * @param array{acl: bool, groups: array<string, array{displayName: string, type: string, permissions: int}>, id: int, manage: array<array-key, array{displayname?: string, id?: string, type?: "group"|"user"|"circle"}>, mount_point: mixed, quota: int, size: int} $folder
+	 * @return array{acl: bool, group_details: array<string, array{displayName: string, type: string, permissions: int}>, groups: array<string, int>, id: int, manage: array<array-key, array{displayname?: string, id?: string, type?: "group"|"user"|"circle"}>, mount_point: mixed, quota: int, size: int}
 	 */
 	private function formatFolder(array $folder): array {
 		// keep compatibility with the old 'groups' field

diff --git a/lib/Folder/FolderManager.php b/lib/Folder/FolderManager.php
@@ -359,7 +359,7 @@ private function getAllApplicable(): array {
 	 * @param CirclesQueryHelper|null $queryHelper
 	 * @param string|null $entityId the type of the entity
 	 *
-	 * @return array{displayname?: string, id?: string, type?: "group"|"user"|"circle"}
+	 * @return array{displayName: string, permissions: int, type: 'circle'|'group'}
 	 */
 	private function generateApplicableMapEntry(
 		array $row,

diff --git a/lib/Listeners/CircleDestroyedEventListener.php b/lib/Listeners/CircleDestroyedEventListener.php
@@ -31,6 +31,9 @@
 use OCP\EventDispatcher\Event;
 use OCP\EventDispatcher\IEventListener;
 
+/**
+ * @template-implements IEventListener<CircleDestroyedEvent>
+ */
 class CircleDestroyedEventListener implements IEventListener {
 	public function __construct(
 		private FolderManager $folderManager,

diff --git a/lib/Listeners/LoadAdditionalScriptsListener.php b/lib/Listeners/LoadAdditionalScriptsListener.php
@@ -27,7 +27,12 @@
 
 use OCP\EventDispatcher\Event;
 use OCP\EventDispatcher\IEventListener;
+use OCA\Files\Event\LoadAdditionalScriptsEvent;
+use OCA\Files_Sharing\Event\BeforeTemplateRenderedEvent;
 
+/**
+ * @template-implements IEventListener<LoadAdditionalScriptsEvent|BeforeTemplateRenderedEvent>
+ */
 class LoadAdditionalScriptsListener implements IEventListener {
 	public function handle(Event $event): void {
 		\OCP\Util::addScript('groupfolders', 'groupfolders-files');

diff --git a/lib/Versions/VersionsBackend.php b/lib/Versions/VersionsBackend.php
@@ -59,18 +59,18 @@ public function useBackendForStorage(IStorage $storage): bool {
 		return true;
 	}
 
-	public function getVersionsForFile(IUser $user, FileInfo $fileInfo): array {
-		$mount = $fileInfo->getMountPoint();
+	public function getVersionsForFile(IUser $user, FileInfo $file): array {
+		$mount = $file->getMountPoint();
 		if (!($mount instanceof GroupMountPoint)) {
 			return [];
 		}
 
 		try {
 			$folderId = $mount->getFolderId();
 			/** @var Folder $versionsFolder */
-			$versionsFolder = $this->getVersionsFolder($mount->getFolderId())->get((string)$fileInfo->getId());
+			$versionsFolder = $this->getVersionsFolder($mount->getFolderId())->get((string)$file->getId());
 
-			$versions = $this->getVersionsForFileFromDB($fileInfo, $user, $folderId);
+			$versions = $this->getVersionsForFileFromDB($file, $user, $folderId);
 
 			// Early exit if we find any version in the database.
 			// Else we continue to populate the DB from what's on disk.
@@ -80,10 +80,10 @@ public function getVersionsForFile(IUser $user, FileInfo $fileInfo): array {
 
 			// Insert the entry in the DB for the current version.
 			$versionEntity = new GroupVersionEntity();
-			$versionEntity->setFileId($fileInfo->getId());
-			$versionEntity->setTimestamp($fileInfo->getMTime());
-			$versionEntity->setSize($fileInfo->getSize());
-			$versionEntity->setMimetype($this->mimeTypeLoader->getId($fileInfo->getMimetype()));
+			$versionEntity->setFileId($file->getId());
+			$versionEntity->setTimestamp($file->getMTime());
+			$versionEntity->setSize($file->getSize());
+			$versionEntity->setMimetype($this->mimeTypeLoader->getId($file->getMimetype()));
 			$versionEntity->setDecodedMetadata([]);
 			$this->groupVersionsMapper->insert($versionEntity);
 
@@ -95,25 +95,25 @@ public function getVersionsForFile(IUser $user, FileInfo $fileInfo): array {
 				}
 
 				$versionEntity = new GroupVersionEntity();
-				$versionEntity->setFileId($fileInfo->getId());
+				$versionEntity->setFileId($file->getId());
 				// HACK: before this commit, versions were created with the current timestamp instead of the version's mtime.
 				// This means that the name of some versions is the exact mtime of the next version. This behavior is now fixed.
 				// To prevent occasional conflicts between the last version and the current one, we decrement the last version mtime.
 				$mtime = (int)$version->getName();
-				if ($mtime === $fileInfo->getMTime()) {
+				if ($mtime === $file->getMTime()) {
 					$versionEntity->setTimestamp($mtime - 1);
 					$version->move($version->getParent()->getPath() . '/' . ($mtime - 1));
 				} else {
 					$versionEntity->setTimestamp($mtime);
 				}
 				$versionEntity->setSize($version->getSize());
 				// Use the main file mimetype for this initialization as the original mimetype is unknown.
-				$versionEntity->setMimetype($this->mimeTypeLoader->getId($fileInfo->getMimetype()));
+				$versionEntity->setMimetype($this->mimeTypeLoader->getId($file->getMimetype()));
 				$versionEntity->setDecodedMetadata([]);
 				$this->groupVersionsMapper->insert($versionEntity);
 			}
 
-			return $this->getVersionsForFileFromDB($fileInfo, $user, $folderId);
+			return $this->getVersionsForFileFromDB($file, $user, $folderId);
 		} catch (NotFoundException $e) {
 			return [];
 		}

diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -1,52 +1,18 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="4.x-dev@">
+<files psalm-version="5.16.0@2897ba636551a8cb61601cc26f6ccfbba6c36591">
   <file src="lib/ACL/ACLStorageWrapper.php">
-    <InvalidNullableReturnType occurrences="2">
+    <InvalidNullableReturnType>
       <code>filemtime</code>
       <code>hash</code>
     </InvalidNullableReturnType>
-    <UndefinedClass occurrences="1">
+    <UndefinedClass>
       <code>IteratorDirectory</code>
     </UndefinedClass>
-    <UndefinedInterfaceMethod occurrences="1">
-      <code>getDirectoryContent</code>
-    </UndefinedInterfaceMethod>
-    <UndefinedMethod occurrences="2">
-      <code>parent::getMetaData($path)</code>
-      <code>parent::writeStream($path, $stream, $size)</code>
-    </UndefinedMethod>
-  </file>
-  <file src="lib/AppInfo/Application.php">
-    <UndefinedClass occurrences="2">
-      <code>BeforeTemplateRenderedEvent</code>
-      <code>CircleDestroyedEvent</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Folder/FolderManager.php">
-    <MismatchingDocblockReturnType occurrences="1">
-      <code>array{id: mixed, mount_point: mixed, groups: array&lt;empty, empty&gt;|mixed, quota: int, size: int|mixed, acl: bool}|false</code>
-    </MismatchingDocblockReturnType>
-  </file>
-  <file src="lib/Helper/LazyFolder.php">
-    <InvalidReturnStatement occurrences="2">
-      <code>$this-&gt;__call(__FUNCTION__, func_get_args())</code>
-      <code>$this-&gt;__call(__FUNCTION__, func_get_args())</code>
-    </InvalidReturnStatement>
-  </file>
-  <file src="lib/Mount/RootPermissionsMask.php">
-    <UndefinedMethod occurrences="1">
-      <code>parent::getMetaData($path)</code>
-    </UndefinedMethod>
-  </file>
-  <file src="lib/Trash/GroupTrashItem.php">
-    <UndefinedMethod occurrences="1">
-      <code>parent::__construct($backend, $originalLocation, $deletedTime, $trashPath, $fileInfo, $user)</code>
-    </UndefinedMethod>
   </file>
   <file src="lib/Versions/ExpireManager.php">
-    <TypeDoesNotContainType occurrences="2">
-      <code>self::MAX_VERSIONS_PER_INTERVAL[$interval]['intervalEndsAfter'] === -1</code>
-      <code>self::MAX_VERSIONS_PER_INTERVAL[$interval]['intervalEndsAfter'] === -1</code>
+    <TypeDoesNotContainType>
+      <code><![CDATA[self::MAX_VERSIONS_PER_INTERVAL[$interval]['intervalEndsAfter'] === -1]]></code>
+      <code><![CDATA[self::MAX_VERSIONS_PER_INTERVAL[$interval]['intervalEndsAfter'] === -1]]></code>
     </TypeDoesNotContainType>
   </file>
 </files>