Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.16] Feature/automate windows file name compatibility #7884

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 19, 2025

Backport of PR #7850

enforce trailing and leading space rules for new files and only for new
files but on all platforms, not only windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to ensure compatibility with Widnows, we will remove automatically the
leading space characters in file name of new files or folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
for now simple rule to guess if the server has windows naming enforced

if windows naming is enforced, we enforce it for new files

if not, we do not care

for now limited to spaces removal

more to come

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
for now simple rule to guess if the server has windows naming enforced

if windows naming is enforced, we enforce it for new files

if not, we do not care

for now limited to spaces removal

more to come

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@backportbot backportbot bot requested review from nilsding and mgallien February 19, 2025 13:12
@backportbot backportbot bot added this to the 3.16.0 milestone Feb 19, 2025
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7884.zip

SHA256 checksum: 1679c5fc90c09e4bd2b13d6634be6a83b2720d9a117d40108c6a8009e2c01d20

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien enabled auto-merge February 19, 2025 13:24
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 507071f into stable-3.16 Feb 19, 2025
13 of 16 checks passed
@mgallien mgallien deleted the backport/7850/stable-3.16 branch February 19, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant