Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide macOS VFS sync states in tray window GUI #7865

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

claucambra
Copy link
Collaborator

No description provided.

Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall :>

build fails when the file providers aren't set to be built though

src/gui/tray/syncstatussummary.cpp Show resolved Hide resolved
@claucambra
Copy link
Collaborator Author

Please do not merge yet, found a bug

@nilsding nilsding self-requested a review February 17, 2025 09:20
@claucambra claucambra force-pushed the bugfix/tray-sync-status-file-provider branch from 71beb39 to 06dce30 Compare February 17, 2025 15:54
@claucambra
Copy link
Collaborator Author

Please do not merge yet, found a bug

Bug has now been fixed @nilsding @mgallien @camilasan

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f simp

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ct that has changed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ay open

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/tray-sync-status-file-provider branch from 06dce30 to 746e349 Compare February 18, 2025 08:19
@mgallien mgallien merged commit 77b622c into master Feb 18, 2025
11 of 14 checks passed
@mgallien mgallien deleted the bugfix/tray-sync-status-file-provider branch February 18, 2025 08:19
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7865.zip

SHA256 checksum: 4fe9d3205403cee2a8b3be4259e45fa8e297bb418f5ba30b3efaa19767eeb48d

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants