Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/automate windows file name compatibility #7850

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien added this to the 3.16.0 milestone Feb 13, 2025
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, tests are failing though (also on windows)

test/testsyncvirtualfiles.cpp Outdated Show resolved Hide resolved
test/testsyncengine.cpp Show resolved Hide resolved
@mgallien mgallien force-pushed the feature/automateWindowsFileNameCompatibility branch 5 times, most recently from ea6279a to 7f908be Compare February 18, 2025 11:03
@mgallien mgallien requested a review from nilsding February 18, 2025 12:04
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some test-related questions :>

test/syncenginetestutils.cpp Show resolved Hide resolved
src/libsync/discovery.cpp Outdated Show resolved Hide resolved
test/testsyncvirtualfiles.cpp Show resolved Hide resolved
test/testlocaldiscovery.cpp Show resolved Hide resolved
enforce trailing and leading space rules for new files and only for new
files but on all platforms, not only windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to ensure compatibility with Widnows, we will remove automatically the
leading space characters in file name of new files or folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
for now simple rule to guess if the server has windows naming enforced

if windows naming is enforced, we enforce it for new files

if not, we do not care

for now limited to spaces removal

more to come

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
for now simple rule to guess if the server has windows naming enforced

if windows naming is enforced, we enforce it for new files

if not, we do not care

for now limited to spaces removal

more to come

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/automateWindowsFileNameCompatibility branch from 24c9944 to eceafab Compare February 19, 2025 12:21
@mgallien mgallien enabled auto-merge February 19, 2025 12:22
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7850.zip

SHA256 checksum: 70a1e60ce319eda2c23108dd5dd05acfc4f0dc3b84b9e978addc9dfc2c5b2974

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71 New Code Smells (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 7170c9c into master Feb 19, 2025
13 of 16 checks passed
@mgallien mgallien deleted the feature/automateWindowsFileNameCompatibility branch February 19, 2025 12:59
@mgallien
Copy link
Collaborator Author

/backport to stable-3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants