-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify AppImage build script to work with an EL8 base #7782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also change the appimage image tag to get it to build with it ?
https://github.com/nextcloud/docker-ci/pkgs/container/continuous-integration-client-appimage-qt6/342014829?tag=client-appimage-el8-6.8.1-1
380338d
to
34813d3
Compare
AppImage file: nextcloud-PR-7782-34813d3ec0782ee5e65bca79c25df6d7d17c703b-x86_64.AppImage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to modify .drone.yml
https://github.com/nextcloud/desktop/blob/master/.drone.yml#L155
5b57ca6
to
1cef01f
Compare
cool, the comment deletion works :D |
2f2b06e
to
7c16a81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my inline comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
.cache is used by clangd on my setup; built AppImages also shouldn't be part of the repo Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
see https://github.com/nextcloud/docker-ci/pkgs/container/continuous-integration-client-appimage-qt6/342431972?tag=client-appimage-el8-6.8.1-2 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
bc46592
to
9340a2e
Compare
Artifact containing the AppImage: nextcloud-appimage-pr-7782.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Quality Gate passedIssues Measures |
these changes are needed to make AppImage builds work with the new Alma8-based image from nextcloud/docker-ci#710