Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify AppImage build script to work with an EL8 base #7782

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

nilsding
Copy link
Member

these changes are needed to make AppImage builds work with the new Alma8-based image from nextcloud/docker-ci#710

@nilsding nilsding added this to the 3.16.0 milestone Jan 22, 2025
@nilsding nilsding requested a review from mgallien January 22, 2025 14:35
@nilsding nilsding self-assigned this Jan 22, 2025
@nilsding nilsding marked this pull request as ready for review January 22, 2025 14:36
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilsding nilsding force-pushed the feature/client-alma8 branch 2 times, most recently from 380338d to 34813d3 Compare January 23, 2025 12:12
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7782-34813d3ec0782ee5e65bca79c25df6d7d17c703b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilsding nilsding force-pushed the feature/client-alma8 branch from 5b57ca6 to 1cef01f Compare January 23, 2025 14:13
@nilsding
Copy link
Member Author

cool, the comment deletion works :D

@nilsding nilsding force-pushed the feature/client-alma8 branch from 2f2b06e to 7c16a81 Compare January 23, 2025 15:16
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my inline comments

@nilsding nilsding requested a review from mgallien January 24, 2025 07:42
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

nilsding and others added 7 commits January 24, 2025 09:07
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
.cache is used by clangd on my setup; built AppImages also shouldn't be
part of the repo

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@mgallien mgallien force-pushed the feature/client-alma8 branch from bc46592 to 9340a2e Compare January 24, 2025 08:08
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7782.zip

SHA256 checksum: 1b7fd418592dc7d7e8be525d7f6dea2c6b1e97c151ed42a0c3aa59805bd68933

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 1f3faaf into master Jan 24, 2025
10 of 15 checks passed
@mgallien mgallien deleted the feature/client-alma8 branch January 24, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants