-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid detecting permissions to be invalid on linux NTFS file system #7745
base: master
Are you sure you want to change the base?
avoid detecting permissions to be invalid on linux NTFS file system #7745
Conversation
Close #7613 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
NTFS file system on Linux reports wrong permissions client believes they need to be fixed but as they cannot, we end-up having an infinite loop Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
AppImage file: nextcloud-PR-7745-c67aa8dde2ed198018cf3d41e91f9739fc2cf222-x86_64.AppImage |
|
#if defined Q_OS_LINUX | ||
const auto fileSystemInfo = QStorageInfo{_localPath}; | ||
qCInfo(lcEngine()) << "File system type for current sync folder:" << fileSystemInfo.fileSystemType(); | ||
if (fileSystemInfo.fileSystemType() == "NTFS") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting
2025-01-10 15:44:55:888 [ info nextcloud.sync.engine /drone/src/src/libsync/syncengine.cpp:645 ]:↦ File system type for current sync folder: "fuseblk"
michael@mars:~$ findmnt /mnt/data
TARGET SOURCE FSTYPE OPTIONS
/mnt/data /dev/nvme0n1p11 fuseblk rw,relatime,user_id=0,group_id=0,allow_other,blksize=4096
michael@mars:~$ grep data /etc/fstab
LABEL=Data /mnt/data ntfs-3g auto 0 0
I built this branch from source on Linux Mint 21.3 Cinnamon and tested it with some folders on NTFS partitions (different partition than the OS). It works sometimes, which was great! But then it stops working and does not sync new files. Either it is stuck in Offline or it is stuck in "preparing sync..." for hours and nothing happens, even though new files are in the folder. Sometimes it also says "checking folder for new files..." The only solution to make sync work again on NTFS partitions is to remove the accounts and re-add them, then it works sometimes. However, syncing a folder on the same partition as the OS, normal ext4 filesystem, is working fine. Also weird, When I add an account, I have to authenticate once when I add it and once more when I reboot the machine for the first time afterwards. Built with Qt 6.8.2. |
this should be fixed with #7768 which was merged after this PR was created (and this branch is currently out-of-date). Should be fine on latest master... |
Close #7613