Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix. Do not treat item type change as metadata update. #6285

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Bugfix. Do not treat item type change as metadata update. #6285

merged 2 commits into from
Dec 13, 2023

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Dec 11, 2023 •
edited
Loading

Will probably fix #6272

@allexzander allexzander mentioned this pull request Dec 11, 2023
Closed
8 tasks
mgallien
mgallien requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add an automated test ?
otherwise sounds good

@mgallien mgallien force-pushed the bugfix/vfs-download-typechange branch 2 times, most recently from 1e5e9fa to d466eb9 Compare December 12, 2023 22:06
@allexzander allexzander force-pushed the bugfix/vfs-download-typechange branch from d466eb9 to 1aff4b6 Compare December 13, 2023 10:40
@allexzander
Bugfix. Do not treat item type change as metadata update.
ed2ad42 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Unit tests for the type change.
4672acb 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/vfs-download-typechange branch from 1aff4b6 to 4672acb Compare December 13, 2023 10:43
@allexzander allexzander requested a review from mgallien December 13, 2023 10:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

2 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

mgallien
mgallien reviewed Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good thanks
feel free to clean history before I approve

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6285-4672acb5a6dd0f056b8478bfc3000439fd10da87-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit b4fcc94 into master Dec 13, 2023
7 of 10 checks passed
@allexzander allexzander deleted the bugfix/vfs-download-typechange branch December 13, 2023 11:53
@allexzander
Copy link
Contributor Author

/backport to stable-3.11

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 13, 2023
Merged
@mgallien mgallien added this to the 3.12.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan camilasan approved these changes

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Sync issue - no info on the problem, clicking the error redirects to the dashboard
4 participants
@allexzander @nextcloud-desktop-bot @mgallien @camilasan