containers-schema: allow to specify ui-secret and show in aio interface #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
szaimen
force-pushed
the
enh/5938/show-secret-in-interface
branch
2 times, most recently
from
d81e046 to
1d4aeb2
Compare
Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/5938/show-secret-in-interface
branch
from
1d4aeb2 to
04ef456
Compare
szaimen
added
3. to review
|
@docjyJ I think this is probably also interesting for you. Please review :) |
docjyJ
previously requested changes
Jan 23, 2025
There was a problem hiding this comment.
Sounds good. Somme sugest:
- Update LLDAP json, Stalwart Readme/Json, NocoDB Readme/Json
- Add field with hide/show (Ex: https://codepen.io/piyush-tapaniya/pen/PvWKKj)
- Add copy button (Ex: https://codepen.io/foxbeefly/pen/dyWbQgJ)
I have not enough time to do that now...
Signed-off-by: Simon L. <szaimen@e.mail.de>
2 tasks
|
Thanks for the review @docjyJ! :)
I have adjusted all except the stalwart readme since that is in your repo...
Can we please do this in a follow-up? I've created #5954 for that :) |
|
This is now released with v10.5.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5938